Skip to content

Implement remaining unimplemented APIs for Builder types #96805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
buyaa-n merged 16 commits into from
Jan 19, 2024
Merged

Implement remaining unimplemented APIs for Builder types #96805

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
5c467a8
Implement 'DefinPInvokeMethod', save required/optional CustomModifier…
buyaa-n Jan 8, 2024
f7c67bc
Add global method, get method impl and tests
buyaa-n Jan 9, 2024
c09a884
Implement DefineInitializedData(...) and UninitializedData(...), refa…
buyaa-n Jan 10, 2024
f0bcf1e
Merge conflicts
buyaa-n Jan 10, 2024
1be0fb3
Apply feedbacks, fix RVA alignment
buyaa-n Jan 11, 2024
9fbe2cf
Update src/libraries/System.Reflection.Emit/src/System/Reflection/Emi…
buyaa-n Jan 11, 2024
408d7f8
Load assemblies in unloadable context
buyaa-n Jan 11, 2024
e6d9333
Merge branch 'more_impl' of github.com:buyaa-n/runtime into more_impl
buyaa-n Jan 11, 2024
948447a
Add period to the messages
buyaa-n Jan 12, 2024
7164991
Apply feedback
buyaa-n Jan 12, 2024
4cfa4b9
Merge branch 'more_impl' of github.com:buyaa-n/runtime into more_impl
buyaa-n Jan 12, 2024
59673e0
Add test for DefineUninitializedData(...)
buyaa-n Jan 16, 2024
bb1f5a7
Set parameter count to 0 for RtFieldInfo
buyaa-n Jan 18, 2024
2627692
Throw when member token is not populated when Module.Get***MetadataTo…
buyaa-n Jan 18, 2024
f36b7cd
Retreiving standalone signature not supported on mono
buyaa-n Jan 18, 2024
9889bc4
Create byte array with the size directly instead of null check
buyaa-n Jan 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update src/libraries/System.Reflection.Emit/src/System/Reflection/Emi… 
…t/TypeBuilderImpl.cs

Co-authored-by: Aaron Robinson <[email protected]>
  • Loading branch information
@buyaa-n @AaronRobinsonMSFT
buyaa-n and AaronRobinsonMSFT authored Jan 11, 2024
commit 9fbe2cfdced0145219e5f278e33b221abfa0bb67
2 changes: 1 addition & 1 deletion src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/TypeBuilderImpl.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ internal sealed class TypeBuilderImpl : TypeBuilder
// Only for creating the global type
internal TypeBuilderImpl(ModuleBuilderImpl module)
{
_name = "<Module>";
_name = "<Module>"; // Defined in ECMA-335 II.10.8
_module = module;
_isHiddenGlobalType = true;
_handle = MetadataTokens.TypeDefinitionHandle(1);
Expand Down