Skip to content

[release/8.0-staging] ServiceKey comparisons use Equals for matching #96847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carlossanlop merged 3 commits into from
Feb 12, 2024
Merged

[release/8.0-staging] ServiceKey comparisons use Equals for matching #96847

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2a7efbd
RemoveAllKeyed use Equals for matching
tommysor Dec 8, 2023
a4bce7a
Use equals for TryAdd and Replace
tommysor Dec 9, 2023
30783fd
Add packaging info to csproj
steveharter Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add packaging info to csproj
  • Loading branch information
@steveharter
steveharter committed Jan 18, 2024
commit 30783fdbfd1ef19ea5d255ee0a8c152cda171be5
2 changes: 2 additions & 0 deletions ...cyInjection.Abstractions/src/Microsoft.Extensions.DependencyInjection.Abstractions.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
<TargetFrameworks>$(NetCoreAppCurrent);$(NetCoreAppPrevious);$(NetCoreAppMinimum);netstandard2.1;netstandard2.0;$(NetFrameworkMinimum)</TargetFrameworks>
<EnableDefaultItems>true</EnableDefaultItems>
<IsPackable>true</IsPackable>
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
<ServicingVersion>1</ServicingVersion>
Comment on lines +7 to +8
Copy link
Contributor

@carlossanlop carlossanlop Feb 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Package authoring changes LGTM.

<PackageDescription>Abstractions for dependency injection.

Commonly Used Types:
Expand Down