Skip to content

JIT: Late expansion for casts #97075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EgorBo merged 17 commits into from
Jan 19, 2024
Merged

JIT: Late expansion for casts #97075

Changes from 2 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
de14015
Late expansion of casts
EgorBo Jan 17, 2024
2c72dea
Fix build
EgorBo Jan 17, 2024
a5345fa
Address feedback
EgorBo Jan 17, 2024
efdeae6
Clean up
EgorBo Jan 17, 2024
587c66e
Improve TP
EgorBo Jan 17, 2024
a72014f
Handle MustNot case
EgorBo Jan 17, 2024
b147e67
Final clean up
EgorBo Jan 17, 2024
aee96f2
No, this is the final clean up
EgorBo Jan 18, 2024
2e6795c
Clean up
EgorBo Jan 18, 2024
a5f7079
Apply suggestions from code review
EgorBo Jan 18, 2024
34523d2
Address feedback
EgorBo Jan 18, 2024
91b47eb
Merge branch 'late-cast-expansion' of github.com:EgorBo/runtime-1 int…
EgorBo Jan 18, 2024
c189b80
remove more code
EgorBo Jan 18, 2024
6684563
clean up
EgorBo Jan 19, 2024
6f42250
Merge branch 'main' of github.com:dotnet/runtime into late-cast-expan…
EgorBo Jan 19, 2024
cdb7b47
Fix control flow
EgorBo Jan 19, 2024
e1122c8
Clean up
EgorBo Jan 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/coreclr/jit/helperexpansion.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ static GenTree* SpillExpression(Compiler* comp, GenTree* expr, BasicBlock* exprB
// Return Value:
// Number of the local that replaces the tree
//
unsigned SplitAtTreeAndReplaceItWithLocal(
static unsigned SplitAtTreeAndReplaceItWithLocal(
Compiler* comp, BasicBlock* block, Statement* stmt, GenTree* tree, BasicBlock** topBlock, BasicBlock** bottomBlock)
{
BasicBlock* prevBb = block;
Expand Down Expand Up @@ -1657,7 +1657,7 @@ PhaseStatus Compiler::fgLateCastExpansion()
// Returns:
// Likely class handle or NO_CLASS_HANDLE
//
CORINFO_CLASS_HANDLE PickLikelyClass(Compiler* comp, IL_OFFSET offset, unsigned* likelihood)
static CORINFO_CLASS_HANDLE PickLikelyClass(Compiler* comp, IL_OFFSET offset, unsigned* likelihood)
{
// TODO-InlineCast: consider merging this helper with pickGDV

Expand Down