Avoid deadlocks in TypeDescriptor #97236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-system-componentmodel Issue DetailsFixes #97179 The new test deadlocked about half of the time before the change here.
|
ericstj
approved these changes
Jan 19, 2024
Member
ericstj
left a comment
ericstj
left a comment
There was a problem hiding this comment.
Nice catch, fix looks reasonable.
ericstj
reviewed
Jan 19, 2024
ericstj
reviewed
Jan 20, 2024
src/libraries/System.ComponentModel.TypeConverter/tests/TypeDescriptorTests.cs
Outdated
Show resolved
Hide resolved
This was referenced Jan 20, 2024
stephentoub
reviewed
Jan 20, 2024
Member
stephentoub
left a comment
stephentoub
left a comment
There was a problem hiding this comment.
Fix LGTM other than Eric's comments on the tests.
2 tasks
Contributor
Author
|
CI failure unrelated: #97241 |
Member
|
LGTM. Thanks for catching this. |
tmds
pushed a commit
to tmds/runtime
that referenced
this pull request
Jan 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #97179
The new test deadlocked about half of the time before the change here.