Skip to content

Late cast expansion: castclass #97237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EgorBo merged 4 commits into from
Jan 22, 2024
Merged

Late cast expansion: castclass #97237

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
82d6598
Move profiled castclass to late phase
EgorBo Jan 19, 2024
9476e0a
Clean up
EgorBo Jan 19, 2024
e39a62b
Update helperexpansion.cpp
EgorBo Jan 20, 2024
cad2e96
Merge branch 'main' into profiled-castclasses-late
EgorBo Jan 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update helperexpansion.cpp
  • Loading branch information
@EgorBo
EgorBo authored Jan 20, 2024
commit e39a62bd78857c91003295be30d709017cf5e7c3
2 changes: 1 addition & 1 deletion src/coreclr/jit/helperexpansion.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2004,7 +2004,7 @@ bool Compiler::fgLateCastExpansionForCall(BasicBlock** pBlock, Statement* stmt,
return false;
}

if ((castResult == TypeCompareState::MustNot) && isInstanceOf)
if ((castResult == TypeCompareState::MustNot) && !isInstanceOf)
{
// Don't expand castclass if likelyclass always fails the type check
// it's going to throw an exception anyway.
Expand Down