Fix access to m_pDynamicStaticsInfo #97353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
davidwrighton
commented
Jan 22, 2024
davidwrighton
commented
- Remove race condition where it is possible that an updated dynamic statics info pointer is published without ensuring that the data is also considered written.
- Use VolatileLoadWithoutBarrier at the read site (where locks are not taken) to ensure that there are no difficult to examine reads of this pointer.
- Remove race condition where it is possible that an updated dynamic statics info pointer is published without ensuring that the data is also considered written. - Use VolatileLoadWithoutBarrier at the read site (where locks are not taken) to ensure that there are no difficult to examine reads of this pointer.
ghost
added
the
jkotas
reviewed
Jan 23, 2024
Member
|
Did you see a crash caused by this issue? |
Member
Author
|
@jkotas No, no crashes caused by this issue have been observed that I have been able to identify. |
Member
Author
Member
|
I would include this fix in the servicing change. The C/C++ compilers can do very surprising reordering. |
davidwrighton
added a commit
that referenced
this pull request
Jan 23, 2024
- Remove race condition where it is possible that an updated dynamic statics info pointer is published without ensuring that the data is also considered written. - Use VolatileLoadWithoutBarrier at the read site (where locks are not taken) to ensure that there are no difficult to examine reads of this pointer.
4 tasks
jeffschwMSFT
pushed a commit
that referenced
this pull request
Feb 9, 2024
…97352) * Move a lock to protect m_pDynamicStaticsInfo * apply feedback * cast to LONG * Fix access to m_pDynamicStaticsInfo (#97353) - Remove race condition where it is possible that an updated dynamic statics info pointer is published without ensuring that the data is also considered written. - Use VolatileLoadWithoutBarrier at the read site (where locks are not taken) to ensure that there are no difficult to examine reads of this pointer. --------- Co-authored-by: Hyungju Lee <[email protected]> Co-authored-by: David Wrighton <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.