Skip to content

JIT: Remove optLoopCompactionFixupFallThrough #97670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amanasifkhalid merged 4 commits into from
Jan 30, 2024
Merged

JIT: Remove optLoopCompactionFixupFallThrough #97670

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e5f2a66
Add branch reversal before reordering
amanasifkhalid Jan 29, 2024
c907c8f
Remove loop fallthrough fixup logic
amanasifkhalid Jan 29, 2024
54aabcb
Remove optLoopCompactionFixupFallThrough
amanasifkhalid Jan 29, 2024
728f22f
Update comment
amanasifkhalid Jan 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update comment
  • Loading branch information
@amanasifkhalid
amanasifkhalid committed Jan 29, 2024
commit 728f22fc990e17454c4a6c56db40ac9adc2bbba5
2 changes: 1 addition & 1 deletion src/coreclr/jit/fgopt.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3491,7 +3491,7 @@ bool Compiler::fgReorderBlocks(bool useProfile)
}
}

// If we will be reordering blocks, re-establish implicit fallthrough for BBJ_COND blocks
// If we will be reordering blocks, ensure the false target of a BBJ_COND block is its next block
if (useProfile)
{
for (BasicBlock* block = fgFirstBB; block != nullptr; block = block->Next())
Expand Down