Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Feb 2, 2024

Backport of #97838 to release/8.0-staging

/cc @thaystg

Customer Impact

  • Customer reported
  • Found internally

A customer reported it by email. Related to dotnet/AspNetCore.Docs#30443
He was testing the documentation and got this behavior when trying to debug on Chrome. If there is a breakpoint set from another debugging session, when the customer presses Alt-Shift-D on Blazor the DevTools is opened but then a crash happens and in the Blazor console app it can see this exception:

fail: DevToolsProxy[0]
      failed: System.InvalidOperationException: Collection was modified; enumeration operation may not execute.
         at System.Collections.Generic.Dictionary`2.ValueCollection.Enumerator.MoveNext()
         at Microsoft.WebAssembly.Diagnostics.MonoProxy.OnSourceFileAdded(SessionId sessionId, SourceFile source, ExecutionContext context, CancellationToken token, Boolean resolveBreakpoints)
         at Microsoft.WebAssembly.Diagnostics.MonoProxy.LoadStore(SessionId sessionId, Boolean tryUseDebuggerProtocol, CancellationToken token)
         at Microsoft.WebAssembly.Diagnostics.MonoProxy.LoadStore(SessionId sessionId, Boolean tryUseDebuggerProtocol, CancellationToken token)

Regression

  • Yes
  • No

I don't know if it works before .NET 8 or something has changed on browser that is causing this race condition. But this is a scenario that was used to work.

Testing

Manually tested.

Risk

Low risk, only looping in a static list and not a list that can be changed while we are looping.

@ghost
Copy link

ghost commented Feb 2, 2024

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #97838 to release/8.0-staging

/cc @thaystg

Customer Impact

  • Customer reported
  • Found internally

[Select one or both of the boxes. Describe how this issue impacts customers, citing the expected and actual behaviors and scope of the issue. If customer-reported, provide the issue number.]

Regression

  • Yes
  • No

[If yes, specify when the regression was introduced. Provide the PR or commit if known.]

Testing

[How was the fix verified? How was the issue missed previously? What tests were added?]

Risk

[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-Debugger-mono

Milestone: -

@thaystg thaystg added the Servicing-consider Issue for next servicing release review label Feb 5, 2024
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. we will take for consideration in 8.0.x

@rbhanda rbhanda added this to the 8.0.3 milestone Feb 8, 2024
@rbhanda rbhanda added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Feb 8, 2024
@lewing lewing merged commit 53c1d13 into release/8.0-staging Feb 9, 2024
@lewing lewing deleted the backport/pr-97838-to-release/8.0-staging branch February 9, 2024 02:25
@github-actions github-actions bot locked and limited conversation to collaborators Mar 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Debugger-mono Servicing-approved Approved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants