Skip to content

Don't call user callbacks on MsQuic worker thread. #98361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rzikm merged 12 commits into from
Feb 28, 2024
Merged

Don't call user callbacks on MsQuic worker thread. #98361

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
74575d4
Allow switching execution profiles using env vars
rzikm Feb 12, 2024
aada566
Quick and dirty version to enable benchmarking
rzikm Feb 12, 2024
5b3d46b
Don't call callbacks from MsQuic threads
rzikm Feb 13, 2024
08cf807
Remove unintentional changes
rzikm Feb 13, 2024
702ea94
Offload parsing to threadpool as well
rzikm Feb 14, 2024
17de07f
Customize TLS ALERT code
rzikm Feb 14, 2024
3b23b49
Code review feedback
rzikm Feb 15, 2024
fce941c
Apply suggestions from code review
rzikm Feb 20, 2024
c595b05
use ConfigureAwaitOptions.ForceYielding
rzikm Feb 20, 2024
6b9142f
Version check to work around https://github.com/microsoft/msquic/issu…
rzikm Feb 26, 2024
9fdb790
Use configure await to yield to threadpool
rzikm Feb 26, 2024
2579291
Fix functionality on older msquic versions
rzikm Feb 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Allow switching execution profiles using env vars
  • Loading branch information
@rzikm
rzikm committed Feb 26, 2024
commit 74575d4eb1e86f1a34d0d0fa61143320c636136c
1 change: 1 addition & 0 deletions src/libraries/System.Net.Quic/src/System.Net.Quic.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@

<ItemGroup>
<Reference Include="Microsoft.Win32.Primitives" />
<Reference Include="System.Console" />
<Reference Include="System.Collections" />
<Reference Include="System.Collections.Concurrent" />
<Reference Include="System.Collections.NonGeneric" />
Expand Down
15 changes: 14 additions & 1 deletion src/libraries/System.Net.Quic/src/System/Net/Quic/Internal/MsQuicApi.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,23 @@ private MsQuicApi(QUIC_API_TABLE* apiTable)

fixed (byte* pAppName = "System.Net.Quic"u8)
{

QUIC_EXECUTION_PROFILE profile = QUIC_EXECUTION_PROFILE.LOW_LATENCY;

if (Environment.GetEnvironmentVariable("DOTNET_QUIC_EXECUTION_PROFILE") is string p)
{
if (Enum.TryParse(p, out QUIC_EXECUTION_PROFILE newProfile))
{
profile = newProfile;
}
}

System.Console.WriteLine($"Execution profile: {profile}");

var cfg = new QUIC_REGISTRATION_CONFIG
{
AppName = (sbyte*)pAppName,
ExecutionProfile = QUIC_EXECUTION_PROFILE.LOW_LATENCY
ExecutionProfile = profile
};

QUIC_HANDLE* handle;
Expand Down