[release/8.0-staging] Fix NativeAOT publish failure on fi_FI culture (#98552) #98601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This culture uses `U+2212 : MINUS SIGN` instead of `-` for negative numbers which trips up msbuild when comparing the property. Instead of using an intermediate property just inline the usage and use `Contains()` for better readability. Fixes dotnet#98550 (cherry picked from commit c768315)
ghost
assigned
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsBackport of #98552 to release/8.0-staging Customer Impact
The fi_FI culture uses Regression
This was introduced in .NET 8 in b969271. TestingTested manually by running RiskLow. This is replacing one way of doing string manipulation with a different one.
|
MichalStrehovsky
approved these changes
Feb 20, 2024
Member
Author
|
Approved by tactics over email. |
akoeplinger
added
Servicing-approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #98552 to release/8.0-staging
/cc @MichalStrehovsky
Customer Impact
The fi_FI culture uses
U+2212 : MINUS SIGNinstead of-for negative numbers which trips up msbuild when comparing a property in NativeAOT targets. This means that using PublishAot doesn't work in that culture.Regression
This was introduced in .NET 8 in b969271.
Testing
Tested manually by running
LANG=fi_FI dotnet publish /p:PublishAot=trueand observing that the msbuild error no longer happens.Risk
Low. This is replacing one way of doing string manipulation with a different one.