Skip to content

Conversation

@stephentoub
Copy link
Member

These doubles need to be formatted with the invariant culture to meet consumer expectations around parsing them.

Fixes #98632

These doubles need to be formatted with the invariant culture to meet consumer expectations around parsing them.
Copy link
Member

@noahfalk noahfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @stephentoub!

@stephentoub stephentoub merged commit 3dc3d85 into dotnet:main Feb 28, 2024
@stephentoub stephentoub deleted the fixmes branch February 28, 2024 12:27
@stephentoub
Copy link
Member Author

/backport to release/8.0-staging

@github-actions
Copy link
Contributor

Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/8081441187

@github-actions github-actions bot locked and limited conversation to collaborators Mar 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MetricsEventSource formats histogram quantiles with CurrentCulture, causing dotnet-counters to misparse them

2 participants