more

src/libraries/System.Collections.Concurrent/tests/ProducerConsumerCollectionTests.cs

@@ -878,7 +878,7 @@ public void ManyConcurrentAddsTakesPeeks_ForceContentionWithOtherThreadsPeeking(
             Assert.Equal(0, c.Count);
         }
 
-        [ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
+        [ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupportedAndBlockingWait))]
         [InlineData(ConcurrencyTestSeconds)]
         public void ManyConcurrentAddsTakes_ForceContentionWithToArray(double seconds)
         {

src/libraries/System.Diagnostics.DiagnosticSource/tests/ActivityTests.cs

@@ -384,7 +384,7 @@ public void IsStoppedTest()
         /// <summary>
         /// Tests Id generation
         /// </summary>
-        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
+        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupportedAndBlockingWait))]
         public void IdGenerationNoParent()
         {
             var orphan1 = new Activity("orphan1");

src/libraries/System.Linq.Expressions/tests/Dynamic/CallSiteCachingTests.cs

@@ -223,7 +223,7 @@ public void BinderCacheFlushWhenTooBig()
 
         }
 
-        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
+        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupportedAndBlockingWait))]
         public void ConcurrentAdds()
         {
             for (int i = 0; i < 10; i++)

src/libraries/System.Linq.Parallel/tests/QueryOperators/GetEnumeratorTests.cs

@@ -164,7 +164,7 @@ public static void GetEnumerator_MoveNextAfterEnd(Labeled<ParallelQuery<int>> la
             Assert.False(enumerator.MoveNext());
         }
 
-        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
+        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupportedAndBlockingWait))]
         public static void GetEnumerator_LargeQuery_PauseAfterOpening()
         {
             using (IEnumerator<int> e = Enumerable.Range(0, 8192).AsParallel().SkipWhile(i => true).GetEnumerator())

src/libraries/System.Linq.Parallel/tests/QueryOperators/OrderByThenByTests.cs

@@ -503,7 +503,7 @@ public static void OrderByDescending_ArgumentNullException()
         // On CTP-M1, this would deadlock for DOP=7,9,11,... on 4-core, but works for DOP=1..6 and 8,10,12, ...
         //
         // In this test, every call to the key-selector delegate throws.
-        [ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
+        [ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupportedAndBlockingWait))]
         [MemberData(nameof(OrderByThreadedData), new[] { 1, 2, 16, 128, 1024 }, new[] { 1, 2, 4, 7, 8, 31, 32 })]
         public static void OrderBy_ThreadedDeadlock(Labeled<ParallelQuery<int>> labeled, int count, int degree)
         {
@@ -515,7 +515,7 @@ public static void OrderBy_ThreadedDeadlock(Labeled<ParallelQuery<int>> labeled,
         }
 
         // Heavily exercises OrderBy, but only throws one user delegate exception to simulate an occasional failure.
-        [ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
+        [ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupportedAndBlockingWait))]
         [MemberData(nameof(OrderByThreadedData), new[] { 1, 2, 16, 128, 1024 }, new[] { 1, 2, 4, 7, 8, 31, 32 })]
         public static void OrderBy_ThreadedDeadlock_SingleException(Labeled<ParallelQuery<int>> labeled, int count, int degree)
         {

src/libraries/System.Runtime/tests/System.IO.Tests/Stream/Stream.NullTests.cs

@@ -194,7 +194,7 @@ public static async Task TestCanceledNullTextReaderAsync(TextReader input)
             input.Dispose();
         }
 
-        [Theory]
+        [ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupportedAndBlockingWait))]
         [MemberData(nameof(NullWriters))]
         public static void TextNullTextWriter(TextWriter output)
         {

src/libraries/System.Runtime/tests/System.Threading.Tasks.Tests/Task/TaskContinueWithTests.cs

@@ -1148,7 +1148,7 @@ public static void RunLazyCancellationTests()
             }
         }
 
-        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
+        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupportedAndBlockingWait))]
         public static void RunLazyCancellationTests_Negative()
         {
             for (int i = 0; i < 2; i++)
@@ -1238,7 +1238,7 @@ public static void LongContinuationChain_ContinueWith_DoesNotStackOverflow()
             t.Wait();
         }
 
-        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
+        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupportedAndBlockingWait))]
         public static void LongContinuationChain_Unwrap_DoesNotStackOverflow()
         {
             const int DiveDepth = 12_000;
@@ -1254,7 +1254,7 @@ public static void LongContinuationChain_Unwrap_DoesNotStackOverflow()
             func(DiveDepth).Wait();
         }
 
-        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
+        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupportedAndBlockingWait))]
         public static void LongContinuationChain_Await_DoesNotStackOverflow()
         {
             const int DiveDepth = 12_000;
@@ -1269,7 +1269,7 @@ await await Task.Factory.StartNew(() => func(count), CancellationToken.None, Tas
             func(0).Wait();
         }
 
-        [ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
+        [ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupportedAndBlockingWait))]
         [InlineData(false)]
         [InlineData(true)]
         public static void TestNoDeadlockOnContinueWithExecuteSynchronously(bool useWaitAll)

src/libraries/System.Threading.RateLimiting/tests/PartitionedRateLimiterTests.cs

@@ -157,7 +157,7 @@ public async Task Create_BlockingWaitDoesNotBlockOtherPartitions()
         }
 
         // Uses Task.Wait in a Task.Run to purposefully test a blocking scenario, this doesn't work on WASM currently
-        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
+        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupportedAndBlockingWait))]
         public async Task Create_BlockingFactoryDoesNotBlockOtherPartitions()
         {
             var limiterFactory = new TrackingRateLimiterFactory<int>();

src/libraries/System.Threading.Tasks.Dataflow/tests/Dataflow/ActionBlockTests.cs

@@ -196,7 +196,7 @@ public async Task TestSchedulerUsage()
             }
         }
 
-        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
+        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupportedAndBlockingWait))]
         public async Task TestInputCount()
         {
             foreach (bool sync in DataflowTestHelpers.BooleanValues)
@@ -253,7 +253,7 @@ public async Task TestOrderMaintained()
             }
         }
 
-        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
+        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupportedAndBlockingWait))]
         public async Task TestNonGreedy()
         {
             foreach (bool sync in DataflowTestHelpers.BooleanValues)
@@ -419,7 +419,7 @@ public async Task TestNullReturnedTasks()
                 actual: sumOfOdds);
         }
 
-        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
+        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupportedAndBlockingWait))]
         public async Task TestParallelExecution()
         {
             int dop = 2;
@@ -439,7 +439,7 @@ public async Task TestParallelExecution()
             }
         }
 
-        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
+        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupportedAndBlockingWait))]
         public async Task TestReleasingOfPostponedMessages()
         {
             foreach (bool sync in DataflowTestHelpers.BooleanValues)

src/libraries/System.Threading.Tasks.Dataflow/tests/Dataflow/BufferBlockTests.cs

@@ -570,7 +570,7 @@ public async Task TestReleasingFailsAtCompletion()
             await Assert.ThrowsAsync<FormatException>(() => bb.Completion);
         }
 
-        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
+        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupportedAndBlockingWait))]
         public async Task TestSynchronousWaitForCompletionDoesNotDeadlock()
         {
             SynchronizationContext origContext = SynchronizationContext.Current;

src/libraries/System.Threading.Tasks.Dataflow/tests/Dataflow/ConcurrentTests.cs

@@ -11,7 +11,7 @@ namespace System.Threading.Tasks.Dataflow.Tests
 {
     public class ConcurrentTests
     {
-        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
+        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupportedAndBlockingWait))]
         [OuterLoop]
         public async Task StressTargetCorePostponement()
         {
@@ -55,7 +55,7 @@ public async Task StressTargetCorePostponement()
         static readonly int s_dop = Environment.ProcessorCount * 2;
         const int IterationCount = 10000;
 
-        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
+        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupportedAndBlockingWait))]
         [OuterLoop] // should be a stress test that runs for a while, but needs cleanup
         public void RunConcurrentTests()
         {

src/libraries/System.Threading.Tasks.Dataflow/tests/Dataflow/DataflowBlockExtensionTests.cs

@@ -454,7 +454,7 @@ public void TestLinkTo_ArgumentValidation()
             Assert.Throws<ArgumentNullException>(() => source.LinkTo(target, null, i => true));
         }
 
-        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
+        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupportedAndBlockingWait))]
         public void TestLinkTo_TwoPhaseCommit()
         {
             var source1 = new BufferBlock<int>();
@@ -478,7 +478,7 @@ public void TestLinkTo_TwoPhaseCommit()
             Assert.Equal(expected: 43, actual: tuple.Item2);
         }
 
-        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
+        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupportedAndBlockingWait))]
         public async Task TestLinkTo_DoubleLinking()
         {
             foreach (bool greedy in DataflowTestHelpers.BooleanValues)
@@ -971,7 +971,7 @@ public async Task TestReceive_AlreadyAvailable()
             Assert.Equal(expected: 0, actual: buffer.Count);
         }
 
-        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
+        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupportedAndBlockingWait))]
         public async Task TestReceive_NotYetAvailable()
         {
             var buffer = new BufferBlock<int>();
@@ -1005,7 +1005,7 @@ public async Task TestReceive_NotYetAvailable()
             Assert.Equal(expected: 6, actual: await t4);
         }
 
-        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
+        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupportedAndBlockingWait))]
         [OuterLoop] // timeout involved
         public async Task TestReceive_Timeout()
         {
@@ -1028,7 +1028,7 @@ public async Task TestReceive_TimeoutZero()
         }
 
 
-        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
+        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupportedAndBlockingWait))]
         public async Task TestReceive_Cancellation()
         {
             var bb = new BufferBlock<int>();
@@ -1070,7 +1070,7 @@ public async Task TestReceive_Cancellation()
             }
         }
 
-        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
+        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupportedAndBlockingWait))]
         public async Task TestReceive_CanceledSource()
         {
             foreach (bool beforeReceive in DataflowTestHelpers.BooleanValues)
@@ -1711,7 +1711,7 @@ public void TestEncapsulate_ArgumentValidation()
                 () => DataflowBlock.Encapsulate<int, int>(new BufferBlock<int>(), new BufferBlock<int>()).Fault(null));
         }
 
-        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
+        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupportedAndBlockingWait))]
         public void TestEncapsulate_LinkingAndUnlinking()
         {
             var buffer = new BufferBlock<int>();

src/libraries/System.Threading.Tasks.Dataflow/tests/Dataflow/TransformBlockTests.cs

@@ -285,7 +285,7 @@ public async Task TestCountZeroAtCompletion()
             Assert.Equal(expected: 0, actual: tb.OutputCount);
         }
 
-        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
+        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupportedAndBlockingWait))]
         public void TestInputCount()
         {
             foreach (bool sync in DataflowTestHelpers.BooleanValues)
@@ -315,7 +315,7 @@ public void TestInputCount()
             }
         }
 
-        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
+        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupportedAndBlockingWait))]
         [OuterLoop] // spins waiting for a condition to be true, though it should happen very quickly
         public async Task TestCount()
         {
@@ -640,7 +640,7 @@ public async Task TestOrdering_Async_OrderedDisabled()
             await tb.Completion;
         }
 
-        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
+        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupportedAndBlockingWait))]
         public async Task TestOrdering_Sync_OrderedDisabled()
         {
             // If ordering were enabled, this test would hang.

src/libraries/System.Threading.Tasks.Dataflow/tests/Dataflow/TransformManyBlockTests.IAsyncEnumerable.cs

@@ -304,7 +304,7 @@ public async Task TestCountZeroAtCompletionAsyncEnumerable()
             Assert.Equal(expected: 0, actual: tb.OutputCount);
         }
 
-        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
+        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupportedAndBlockingWait))]
         public void TestInputCountAsyncEnumerable()
         {
             using Barrier barrier1 = new Barrier(2), barrier2 = new Barrier(2);
@@ -330,7 +330,7 @@ IAsyncEnumerable<int> body(int item)
             }
         }
 
-        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
+        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupportedAndBlockingWait))]
         [OuterLoop] // spins waiting for a condition to be true, though it should happen very quickly
         public async Task TestCountAsyncEnumerable()
         {
@@ -630,7 +630,7 @@ public async Task TestOrdering_Sync_OrderedEnabledAsyncEnumerable(int mmpt, int
             await tb.Completion;
         }
 
-        [ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
+        [ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupportedAndBlockingWait))]
         [InlineData(true)]
         [InlineData(false)]
         public async Task TestOrdering_Sync_OrderedDisabledAsyncEnumerable(bool trustedEnumeration)
@@ -658,7 +658,7 @@ public async Task TestOrdering_Sync_OrderedDisabledAsyncEnumerable(bool trustedE
             await tb.Completion;
         }
 
-        [ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
+        [ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupportedAndBlockingWait))]
         [InlineData(false)]
         [InlineData(true)]
         public async Task TestOrdering_Sync_BlockingEnumeration_NoDeadlockAsyncEnumerable(bool ensureOrdered)

src/libraries/System.Threading.Tasks.Dataflow/tests/Dataflow/TransformManyBlockTests.cs

@@ -313,7 +313,7 @@ public async Task TestCountZeroAtCompletion()
             Assert.Equal(expected: 0, actual: tb.OutputCount);
         }
 
-        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
+        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupportedAndBlockingWait))]
         public void TestInputCount()
         {
             foreach (bool sync in DataflowTestHelpers.BooleanValues)
@@ -343,7 +343,7 @@ public void TestInputCount()
             }
         }
 
-        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
+        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupportedAndBlockingWait))]
         [OuterLoop] // spins waiting for a condition to be true, though it should happen very quickly
         public async Task TestCount()
         {
@@ -753,7 +753,7 @@ public async Task TestOrdering_Async_OrderedDisabled(bool trustedEnumeration)
             await tb.Completion;
         }
 
-        [ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
+        [ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupportedAndBlockingWait))]
         [InlineData(true)]
         [InlineData(false)]
         public async Task TestOrdering_Sync_OrderedDisabled(bool trustedEnumeration)
@@ -781,7 +781,7 @@ public async Task TestOrdering_Sync_OrderedDisabled(bool trustedEnumeration)
             await tb.Completion;
         }
 
-        [ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
+        [ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupportedAndBlockingWait))]
         [InlineData(false)]
         [InlineData(true)]
         public async Task TestOrdering_Sync_BlockingEnumeration_NoDeadlock(bool ensureOrdered)

src/libraries/System.Threading.Tasks.Dataflow/tests/Dataflow/WriteOnceBlockTests.cs

@@ -173,7 +173,7 @@ public async Task TestPostThenReceive()
             await wob.Completion;
         }
 
-        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
+        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupportedAndBlockingWait))]
         public async Task TestReceiveThenPost()
         {
             var wob = new WriteOnceBlock<int>(null);