Skip to content

Set assets manifest metadata for assets that get shipped with .NET release #98824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ViktorHofer merged 4 commits into from
Feb 23, 2024
Merged

Set assets manifest metadata for assets that get shipped with .NET release #98824

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
957bdc3
add metadata to manifest
MilenaHristova Feb 22, 2024
3f1f958
set in ItemDefinitionGroup
MilenaHristova Feb 23, 2024
75535c5
remove from items
MilenaHristova Feb 23, 2024
69a6996
comment
MilenaHristova Feb 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
add metadata to manifest
  • Loading branch information
@MilenaHristova
MilenaHristova committed Feb 22, 2024
commit 957bdc3afbfdcd2e7e1a9d195fbf08b2ca9edc7e
17 changes: 15 additions & 2 deletions src/installer/prepare-artifacts.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@
</PropertyGroup>
<Import Project="../tools/Sign.props" Sdk="Microsoft.DotNet.Arcade.Sdk" />

<Import Project="$(RepositoryEngineeringDir)Publishing.props" Condition="Exists('$(RepositoryEngineeringDir)Publishing.props')" />

<UsingTask TaskName="GenerateChecksums" AssemblyFile="$(InstallerTasksAssemblyPath)" />

<PropertyGroup>
Expand Down Expand Up @@ -102,36 +104,47 @@
<ItemGroup>
<ItemsToPush Remove="@(ItemsToPush)" />

<ItemsToPush Include="@(ShippingNupkgToPublishFile)" />
<ItemsToPush Include="@(ShippingNupkgToPublishFile)">
<ManifestArtifactData Condition="'$(ProducesDotNetReleaseShippingAssets)' == 'true'">DotNetReleaseShipping=true</ManifestArtifactData>
</ItemsToPush>

<ItemsToPush Include="@(NonShippingNupkgToPublishFile)" ManifestArtifactData="NonShipping=true" />
<ItemsToPush Include="@(SymbolNupkgToPublishFile)" />

<ItemsToPush Include="@(SymbolNupkgToPublishFile)">
<ManifestArtifactData Condition="'$(ProducesDotNetReleaseShippingAssets)' == 'true'">DotNetReleaseShipping=true</ManifestArtifactData>
</ItemsToPush>

<ItemsToPush
Include="@(UploadToBlobStorageFile)"
Exclude="@(NupkgToPublishFile);@(SymbolNupkgToPublishFile)">
<RelativeBlobPath>$(InstallersRelativePath)%(Filename)%(Extension)</RelativeBlobPath>
<PublishFlatContainer>true</PublishFlatContainer>
<ManifestArtifactData Condition="'$(ProducesDotNetReleaseShippingAssets)' == 'true'">DotNetReleaseShipping=true</ManifestArtifactData>
</ItemsToPush>

<ItemsToPush Include="@(GeneratedChecksumFile)">
<RelativeBlobPath>$(InstallersRelativePath)%(Filename)%(Extension)</RelativeBlobPath>
<Category>Checksum</Category>
<PublishFlatContainer>true</PublishFlatContainer>
<ManifestArtifactData Condition="'$(ProducesDotNetReleaseShippingAssets)' == 'true'">DotNetReleaseShipping=true</ManifestArtifactData>
</ItemsToPush>

<ItemsToPush Include="$(ArtifactsShippingPackagesDir)productVersion.txt">
<RelativeBlobPath>$(InstallersRelativePath)productVersion.txt</RelativeBlobPath>
<PublishFlatContainer>true</PublishFlatContainer>
<ManifestArtifactData Condition="'$(ProducesDotNetReleaseShippingAssets)' == 'true'">DotNetReleaseShipping=true</ManifestArtifactData>
</ItemsToPush>

<ItemsToPush Include="$(ArtifactsShippingPackagesDir)runtime-productVersion.txt">
<RelativeBlobPath>$(InstallersRelativePath)runtime-productVersion.txt</RelativeBlobPath>
<PublishFlatContainer>true</PublishFlatContainer>
<ManifestArtifactData Condition="'$(ProducesDotNetReleaseShippingAssets)' == 'true'">DotNetReleaseShipping=true</ManifestArtifactData>
</ItemsToPush>

<ItemsToPush Include="@(WorkloadsVSInsertionFile)">
<RelativeBlobPath>$(InstallersRelativePath)workloads/%(Filename)%(Extension)</RelativeBlobPath>
<PublishFlatContainer>true</PublishFlatContainer>
<ManifestArtifactData Condition="'$(ProducesDotNetReleaseShippingAssets)' == 'true'">DotNetReleaseShipping=true</ManifestArtifactData>
Copy link
Member

@ViktorHofer ViktorHofer Feb 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using an ItemDefinitionGroup instead of all these manual metadata updates.

Copy link
Contributor Author

@MilenaHristova MilenaHristova Feb 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, I didn't know about this. How about now?

</ItemsToPush>

<!-- Source build intermediated packages will be pushed and signed by the sourcebuild leg. -->
Expand Down