Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Feb 23, 2024

Backport of #98677 to release/8.0-staging

/cc @jkoritzinsky @mpidash

Customer Impact

This issue was causing build warnings at build time and yellow-bars in VS that the user cannot fix.

Regression

  • Yes
  • No

Testing

We added unit tests to validate the scenarios that were displaying the issue.

Risk

Low risk, the change is only in analyzer and we have high confidence in our testing suite.

@ghost
Copy link

ghost commented Feb 23, 2024

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #98677 to release/8.0-staging

/cc @jkoritzinsky @mpidash

Customer Impact

  • Customer reported
  • Found internally

[Select one or both of the boxes. Describe how this issue impacts customers, citing the expected and actual behaviors and scope of the issue. If customer-reported, provide the issue number.]

Regression

  • Yes
  • No

[If yes, specify when the regression was introduced. Provide the PR or commit if known.]

Testing

[How was the fix verified? How was the issue missed previously? What tests were added?]

Risk

[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-System.Runtime.InteropServices

Milestone: -

@jkoritzinsky jkoritzinsky added the Servicing-consider Issue for next servicing release review label Feb 23, 2024
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. we will take for consideration in 8.0.x

@jeffschwMSFT jeffschwMSFT added this to the 8.0.x milestone Feb 27, 2024
@leecow leecow added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Feb 27, 2024
@leecow leecow modified the milestones: 8.0.x, 8.0.4 Feb 27, 2024
@carlossanlop
Copy link
Contributor

Friendly reminder that Monday March 11th is the Code Complete date for the April Release. If you want this change to be included in that release, please make sure to merge this before that date.

@jkoritzinsky jkoritzinsky merged commit c897573 into release/8.0-staging Mar 11, 2024
@jkoritzinsky jkoritzinsky deleted the backport/pr-98677-to-release/8.0-staging branch March 11, 2024 20:49
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants