Skip to content

[release/8.0-staging] Add ProducesNetCoreAssets property to Publishing.props #98988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ViktorHofer merged 4 commits into from
Mar 7, 2024
Merged

[release/8.0-staging] Add ProducesNetCoreAssets property to Publishing.props #98988

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0abc035
add property to publishing.props
MilenaHristova Feb 19, 2024
4704dc4
rename to ProducesDotNetReleaseShippingAssets
MilenaHristova Feb 21, 2024
5c03c07
Update Publishing.props
ViktorHofer Feb 22, 2024
1b1f6f9
Set assets manifest metadata for assets that get shipped with .NET re…
MilenaHristova Feb 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Set assets manifest metadata for assets that get shipped with .NET re… 
…lease (#98824)

* add metadata to manifest

* set in ItemDefinitionGroup

* remove from items

* comment
  • Loading branch information
@MilenaHristova
MilenaHristova committed Feb 27, 2024
commit 1b1f6f952e4af2c5229cc084dc65fa731d97cdc5
12 changes: 12 additions & 0 deletions src/installer/prepare-artifacts.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@
</PropertyGroup>
<Import Project="../tools/Sign.props" Sdk="Microsoft.DotNet.Arcade.Sdk" />

<Import Project="$(RepositoryEngineeringDir)Publishing.props" Condition="Exists('$(RepositoryEngineeringDir)Publishing.props')" />

<UsingTask TaskName="GenerateChecksums" AssemblyFile="$(InstallerTasksAssemblyPath)" />

<PropertyGroup>
Expand Down Expand Up @@ -56,6 +58,16 @@
<ManifestBuildData Include="AzureDevOpsBranch=$(BUILD_SOURCEBRANCH)" />
</ItemGroup>

<!--
Set metadata for assets that are not marked as NonShipping.
This is used to determine if the asset should be shipped as part of .NET release.
-->
<ItemDefinitionGroup>
<ItemsToPush>
<ManifestArtifactData Condition="'$(ProducesDotNetReleaseShippingAssets)' == 'true'">DotNetReleaseShipping=true</ManifestArtifactData>
</ItemsToPush>
</ItemDefinitionGroup>

<!--
Run Arcade's signing project directly. The 'eng/Signing.props' extensibility props file checks
if '$(<StageName>)' == 'true' and points Arcade to the correct files.
Expand Down