-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Always keep global symbols on ApplePlatforms #99504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
|
cc @mikem8361, this preserves the symbol in executable. Note that symbol was always there but stripped in a separate dSYM file |
|
I've validated that the changes work for my native AOT test app. |
|
Should we backport this to 8.0? |
Agreed. @mikem8361 or @MichalStrehovsky would you be interested in starting the backport approval process? |
I would appreciate if Mike could drive that. I haven't used anything made by Apple for years and I'm not able to reason about risks/impact of this PR (can't even try it as I don't have a Mac). |
|
/backport to release/8.0-staging |
|
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/8256687078 |
Fixes #99503