Skip to content

Conversation

@am11
Copy link
Member

@am11 am11 commented Mar 10, 2024

Fixes #99503

@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Mar 10, 2024
@am11
Copy link
Member Author

am11 commented Mar 10, 2024

cc @mikem8361, this preserves the symbol in executable. Note that symbol was always there but stripped in a separate dSYM file {binary}.dSYM/Contents/Resources/DWARF/{binary}, now it is part of the binary. Size overhead in console app binary is 32 bytes and webapiaot app is 48 bytes.

@jkotas jkotas requested a review from mikem8361 March 10, 2024 23:03
@mikem8361
Copy link
Contributor

I've validated that the changes work for my native AOT test app.

@mikem8361 mikem8361 merged commit d019c1b into dotnet:main Mar 11, 2024
@filipnavara filipnavara deleted the patch-30 branch March 11, 2024 17:48
@filipnavara filipnavara restored the patch-30 branch March 11, 2024 17:49
@filipnavara filipnavara deleted the patch-30 branch March 11, 2024 17:49
@mikem8361
Copy link
Contributor

Should we backport this to 8.0?

@tommcdon

@tommcdon
Copy link
Member

Should we backport this to 8.0?

Agreed. @mikem8361 or @MichalStrehovsky would you be interested in starting the backport approval process?

@MichalStrehovsky
Copy link
Member

Should we backport this to 8.0?

Agreed. @mikem8361 or @MichalStrehovsky would you be interested in starting the backport approval process?

I would appreciate if Mike could drive that. I haven't used anything made by Apple for years and I'm not able to reason about risks/impact of this PR (can't even try it as I don't have a Mac).

@mikem8361
Copy link
Contributor

/backport to release/8.0-staging

@github-actions
Copy link
Contributor

Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/8256687078

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-NativeAOT-coreclr community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Native AOT SOS debugging on MacOS isn't working

4 participants