Skip to content

[release/8.0-staging] disable optimizations for PopCount #99832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeffschwMSFT merged 2 commits into from
Mar 15, 2024
Merged

[release/8.0-staging] disable optimizations for PopCount #99832

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1757ebf
disable optimizations for PopCount
mangod9 Mar 15, 2024
579a8ce
remove whitespace for jit-format
mangod9 Mar 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
disable optimizations for PopCount 
avoid using an optimization which might fail on non-SSE4 cpus.
  • Loading branch information
@mangod9
mangod9 authored and github-actions committed Mar 15, 2024
commit 1757ebfa46d3f8c66170b1ca971fa3b8f3f1371d
8 changes: 8 additions & 0 deletions src/coreclr/jit/utils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3192,6 +3192,11 @@ uint32_t BitOperations::Log2(uint64_t value)
// Return Value:
// The population count (number of bits set) of value
//
#if defined(_MSC_VER)
// Disable optimizations for PopCount to avoid the compiler from generating intrinsics
// not supported on all platforms.
#pragma optimize("", off)
#endif // _MSC_VER
uint32_t BitOperations::PopCount(uint32_t value)
{
#if defined(_MSC_VER)
Expand Down Expand Up @@ -3244,6 +3249,9 @@ uint32_t BitOperations::PopCount(uint64_t value)
return static_cast<uint32_t>(result);
#endif
}
#if defined(_MSC_VER)
#pragma optimize("", on)
#endif // _MSC_VER

//------------------------------------------------------------------------
// BitOperations::ReverseBits: Reverses the bits in an integer value
Expand Down