Skip to content

Conversation

@thaystg
Copy link
Member

@thaystg thaystg commented Mar 15, 2024

Backport of #99843 to release/8.0-staging

Customer Impact

  • Customer reported
  • Found internally

Reported by customers in dotnet/android#8792. While debugging a MAUI/Blazor Wasm app and it's paused in a breakpoint/stepping and there is any local that is of type Span the runtime will throw an assertion and finish the debugging session.

Regression

  • Yes it works on .NET 7
  • No

Testing

  • Manually tested.
  • Unit tests were added to prevent the fix from regressing.

Risk

Low. The change only checks if the value that is coming from SDB is NULL and then do not throw the assertion.

@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

@lambdageek
Copy link
Member

@thaystg looks like the bot didn't put the backport template in the description for some reason

@thaystg
Copy link
Member Author

thaystg commented Mar 18, 2024

@thaystg looks like the bot didn't put the backport template in the description for some reason

This is because I did it manually. I will add the template and fill it.

@thaystg thaystg added the Servicing-consider Issue for next servicing release review label Mar 18, 2024
@lambdageek lambdageek added this to the 8.0.x milestone Mar 18, 2024
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. we will take for consideration in 8.0.x

@rbhanda rbhanda modified the milestones: 8.0.x, 8.0.5 Mar 21, 2024
@rbhanda rbhanda added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Mar 21, 2024
@AArnott
Copy link
Contributor

AArnott commented Mar 28, 2024

@jeffschwMSFT I'd sure love for this to be taken. It's completely blocking testing an android app that I've been (personally) developing.

@jeffschwMSFT
Copy link
Member

it is approved for 8.0.5 shipping in May

@thaystg thaystg merged commit 9de64a2 into dotnet:release/8.0-staging Apr 2, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Debugger-mono Servicing-approved Approved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants