Skip to content

Detect generic recursion in generic lookups #1699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MichalStrehovsky merged 3 commits into from
Nov 3, 2021
Merged

Detect generic recursion in generic lookups #1699

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ed8244d
Detect generic recursion in generic lookups
MichalStrehovsky Nov 3, 2021
609b161
Add test
MichalStrehovsky Nov 3, 2021
a8c6e65
Ignore fields for now
MichalStrehovsky Nov 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Detect generic recursion in generic lookups
  • Loading branch information
@MichalStrehovsky
MichalStrehovsky committed Nov 3, 2021
commit ed8244d906ce0d1991bf6e05e2775b3a37f7780c
5 changes: 5 additions & 0 deletions src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/Compilation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,6 +317,11 @@ public ISymbolNode ComputeConstantLookup(ReadyToRunHelperId lookupKind, object t

public GenericDictionaryLookup ComputeGenericLookup(MethodDesc contextMethod, ReadyToRunHelperId lookupKind, object targetOfLookup)
{
if (targetOfLookup is TypeSystemEntity typeSystemEntity)
{
_nodeFactory.TypeSystemContext.DetectGenericCycles(contextMethod, typeSystemEntity);
}

GenericContextSource contextSource;

if (contextMethod.RequiresInstMethodDescArg())
Expand Down