Skip to content

Implement infra to support marshalling blittable generics (equivalent to .NET 5 support) #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkoritzinsky merged 13 commits into from
Sep 3, 2020
Merged

Implement infra to support marshalling blittable generics (equivalent to .NET 5 support) #80

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
a3d62b0
Add new attribute to enable marking types with generic fields as cond…
jkoritzinsky Sep 2, 2020
2e8e5d3
Implement support for marking generic types as blittable when the gen…
jkoritzinsky Sep 2, 2020
175ef81
Update design for generics to support nested types and field with typ…
jkoritzinsky Sep 2, 2020
6cd4439
Change generics support to be an extension of BlittableTypeAttribute …
jkoritzinsky Sep 3, 2020
2348f08
Remove definition of new attriutes in Ancillary.Interop
jkoritzinsky Sep 3, 2020
f1a4b61
Re-run resx generator to update generated code.
jkoritzinsky Sep 3, 2020
1965dbd
More cleanup after changing design.
jkoritzinsky Sep 3, 2020
765e854
Fix extra mention of the removed attribute in resources.
jkoritzinsky Sep 3, 2020
41c3df6
PR feedback.
jkoritzinsky Sep 3, 2020
f6cc1e8
Change parameter back to ITypeSymbol.
jkoritzinsky Sep 3, 2020
bd5bc26
More cleanup.
jkoritzinsky Sep 3, 2020
50ad335
Simplify pattern match
jkoritzinsky Sep 3, 2020
c36a841
Update DllImportGenerator/designs/StructMarshalling.md
jkoritzinsky Sep 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Simplify pattern match 
Signed-off-by: Jeremy Koritzinsky <jekoritz@microsoft.com>
  • Loading branch information
@jkoritzinsky
jkoritzinsky committed Sep 3, 2020
commit 50ad3356edb20f4bf72451f000591e9a2a7e96ff
2 changes: 1 addition & 1 deletion DllImportGenerator/DllImportGenerator/TypeSymbolExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public static bool HasOnlyBlittableFields(this ITypeSymbol type)
not { Type : { SpecialType : SpecialType.None }} => IsSpecialTypeBlittable(field.Type.SpecialType),
// Assume that type parameters that can be blittable are blittable.
// We'll re-evaluate blittability for generic fields of generic types at instantation time.
{ Type : ITypeParameterSymbol { IsReferenceType: false } t } => true,
{ Type : ITypeParameterSymbol } => true,
{ Type : { IsValueType : false }} => false,
// A recursive struct type isn't blittable.
// It's also illegal in C#, but I believe that source generators run
Expand Down