Skip to content

Revert "Rationalize default Imports for C# and VB" #18990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
marcpopMSFT wants to merge 4 commits into from
Closed

Revert "Rationalize default Imports for C# and VB" #18990

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0c48eba
Revert "Rationalize default Imports for C# and VB"
marcpopMSFT Jul 16, 2021
4c4e2ff
Update Microsoft.NET.Sdk.DefaultItems.props
marcpopMSFT Jul 16, 2021
170e13d
Update Microsoft.NET.Sdk.VisualBasic.targets
marcpopMSFT Jul 16, 2021
2d00da7
Update GivenThatICareAboutVBApps.cs
marcpopMSFT Jul 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update GivenThatICareAboutVBApps.cs 
Revert the test from #18853
  • Loading branch information
@marcpopMSFT
marcpopMSFT authored Jul 16, 2021
commit 2d00da7a2249a37fd7b3fbbebeb5a4258d92cd37
24 changes: 0 additions & 24 deletions src/Tests/dotnet.Tests/GivenThatICareAboutVBApps.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,30 +20,6 @@ public GivenThatICareAboutVBApps(ITestOutputHelper log) : base(log)
{
}

[Fact]
public void ICanRemoveSpecificImportsInProjectFile()
{
var testProject = new TestProject
{
IsExe = true,
TargetFrameworks = "netcoreapp3.0",
ProjectSdk = "Microsoft.NET.Sdk"
};
testProject.SourceFiles["Program.vb"] = @"
Module Program
Sub Main(args As String())
Console.WriteLine(""Hello World!"")
End Sub
End Module
";
testProject.AdditionalItems["Import"] = new Dictionary<string, string> { ["Remove"] = "System" };
var testInstance = _testAssetsManager.CreateTestProject(testProject);

new BuildCommand(testInstance)
.Execute()
.Should().Fail();
}

[Fact]
public void ICanBuildVBApps()
{
Expand Down