Skip to content

Update handling of SelfContained and RuntimeIdentifier properties when specified on the command line #21986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsplaisted merged 12 commits into from
Aug 22, 2022
Merged

Update handling of SelfContained and RuntimeIdentifier properties when specified on the command line #21986

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
5c8503a
Improve handling of RuntimeIdentifier and SelfContained across projec…
dsplaisted Oct 12, 2021
5f4ba10
Add test for SelfContained flowing across project reference
dsplaisted Oct 12, 2021
63ae00b
Move AcceptsRuntimeIdentifier logic and exclude test projects
dsplaisted Oct 12, 2021
bf9b7a3
Add breaking change information
dsplaisted Oct 12, 2021
45f8979
Detect whether SelfContained is a global property inside task
dsplaisted Oct 18, 2021
117a1c9
Handle consuming AcceptsRuntimeIdentifier metadata from multi-targete…
dsplaisted Dec 3, 2021
26df179
Use IsRidAgnostic instead of AcceptsRuntimeIdentifier
dsplaisted Aug 12, 2022
579ad7f
Handle more cases of global property flow
dsplaisted Aug 18, 2022
4468b0b
Add tests for global property flow across project references
dsplaisted Aug 18, 2022
8a303dd
Code review feedback
dsplaisted Aug 19, 2022
27fe291
Require updated MSBuild for global property flow tests
dsplaisted Aug 22, 2022
4d634e9
Fix tests
dsplaisted Aug 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Code review feedback
  • Loading branch information
@dsplaisted
dsplaisted committed Aug 19, 2022
commit 8a303dd7140d2350e0f0400080fefba6d590f290
2 changes: 1 addition & 1 deletion documentation/general/SelfContainedBreakingChangeNotification.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ If `SelfContained` was specified on the command line, it would always flow to re

## New Behavior

Both `SelfContained` and `RuntimeIdentifier` will flow a referenced project if any of the following are true for the referenced project:
Both `SelfContained` and `RuntimeIdentifier` will flow to a referenced project if any of the following are true for the referenced project:

- The `IsRidAgnostic` property is set to `false`
- The `OutputType` is `Exe` or `WinExe`
Expand Down