[main] Update dependencies from dotnet/arcade

[dotnet-maestro]

This pull request updates the following dependencies

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

• Coherency Updates:
  • Microsoft.DotNet.XliffTasks: from 1.0.0-beta.22409.1 to 1.0.0-beta.22425.1 (parent: Microsoft.DotNet.Arcade.Sdk)

From https://github.com/dotnet/arcade

• Subscription: 3d9043af-0e17-4eb5-f3e3-08d8e97c775d
• Build: 20220826.8
• Date Produced: August 27, 2022 12:03:43 AM UTC
• Commit: 14df52bae2c74fc850a8c40fe68ea5be5cd30116
• Branch: refs/heads/main

• Updates:
  • Microsoft.DotNet.Arcade.Sdk: from 7.0.0-beta.22411.2 to 7.0.0-beta.22426.8
  • Microsoft.DotNet.Helix.Sdk: from 7.0.0-beta.22411.2 to 7.0.0-beta.22426.8
  • Microsoft.DotNet.SignTool: from 7.0.0-beta.22411.2 to 7.0.0-beta.22426.8
  • Microsoft.DotNet.XUnitExtensions: from 7.0.0-beta.22411.2 to 7.0.0-beta.22426.8
  • Microsoft.DotNet.XliffTasks: from 1.0.0-beta.22409.1 to 1.0.0-beta.22425.1

[marcpopMSFT]

@dotnet/domestic-cat this updates the sdk from preview 5 to preview 7 and appears to break the build. Probably needs a source file update.

[dsplaisted]

@jkoritzinsky @Youssef1313 @mavasani @jmarolf We are getting this error when building the dotnet/sdk repo with a preview 7 SDK:

C:\git\dotnet-sdk2\src\Resolvers\Microsoft.DotNet.NativeWrapper\Interop.cs(187,54): error CA1420: Delegates with managed types as parameters or the return type require runtime marshalling to be enabled in the assembly where the delegate is defined. [C:\git\dotnet-sdk2\src\Resolvers\Microsoft.DotNet.NativeWrapper\Microsoft.DotNet.NativeWrapper.csproj]

Based on dotnet/runtime#63714, it seems like this should only be generated if we opt in with DisableRuntimeMarshallingAttribute, which I don't believe we are doing.

Can you investigate and help us get this building correctly with the new SDK?

[jkoritzinsky]

That's a bug in the analyzer. I just put out a PR with a fix to dotnet/roslyn-analyzers#6124.

Best option might be to manually disable the warning in source until the fix is available.

[marcpopMSFT]

@dotnet/templating-engine-maintainers there are a bunch of test failures in the template engine legs. Mind taking a look?

[vlada-shubina]

Same as #27286 (comment)

[wtgodbe]

@javiercn could you fix this one up as well?

[javiercn]

@wtgodbe I did my part, but there are other issues in the PR

[javiercn]

@wtgodbe FYI, cf986aa this commit automates the process to update the baselines (clone, build the repo, run the script) we might want to port it to RC1

[danmoseley]

@dotnet/domestic-cat some new compiler errors have been introduced. Could you please fix? This also will unblock ingesting runtime.

2022-08-27T12:39:59.4929569Z D:\a\1\s\src\Tests\Microsoft.Extensions.DotNetDeltaApplier.Tests\StartupHookTests.cs(28,26): error CS8604: Possible null reference argument for parameter 'collection' in 'void Assert.Empty(IEnumerable collection)'. [D:\a\1\s\src\Tests\Microsoft.Extensions.DotNetDeltaApplier.Tests\Microsoft.Extensions.DotNetDeltaApplier.Tests.csproj]
2022-08-27T12:39:59.4931877Z D:\a\1\s\src\Tests\Microsoft.TemplateEngine.Cli.UnitTests\HostDataLoaderTests.cs(43,78): error CS8604: Possible null reference argument for parameter 'collection' in 'void Assert.Contains<string>(string expected, IEnumerable<string> collection)'. [D:\a\1\s\src\Tests\Microsoft.TemplateEngine.Cli.UnitTests\Microsoft.TemplateEngine.Cli.UnitTests.csproj]
2022-08-27T12:39:59.4955512Z D:\a\1\s\src\Tests\Microsoft.TemplateEngine.Cli.UnitTests\HostDataLoaderTests.cs(86,78): error CS8604: Possible null reference argument for parameter 'collection' in 'void Assert.Contains<string>(string expected, IEnumerable<string> collection)'. [D:\a\1\s\src\Tests\Microsoft.TemplateEngine.Cli.UnitTests\Microsoft.TemplateEngine.Cli.UnitTests.csproj]
2022-08-27T12:39:59.4958662Z D:\a\1\s\src\Tests\Microsoft.TemplateEngine.Cli.UnitTests\ParserTests\UpdateTests.cs(25,27): error CS8604: Possible null reference argument for parameter 'collection' in 'string Assert.Single<string>(IEnumerable<string> collection)'. [D:\a\1\s\src\Tests\Microsoft.TemplateEngine.Cli.UnitTests\Microsoft.TemplateEngine.Cli.UnitTests.csproj]
2022-08-27T12:39:59.4979352Z D:\a\1\s\src\Tests\Microsoft.TemplateEngine.Cli.UnitTests\ParserTests\UpdateTests.cs(55,50): error CS8604: Possible null reference argument for parameter 'collection' in 'void Assert.Contains<string>(string expected, IEnumerable<string> collection)'. [D:\a\1\s\src\Tests\Microsoft.TemplateEngine.Cli.UnitTests\Microsoft.TemplateEngine.Cli.UnitTests.csproj]
2022-08-27T12:39:59.4986837Z D:\a\1\s\src\Tests\Microsoft.TemplateEngine.Cli.UnitTests\ParserTests\UpdateTests.cs(124,27): error CS8604: Possible null reference argument for parameter 'collection' in 'string Assert.Single<string>(IEnumerable<string> collection)'. [D:\a\1\s\src\Tests\Microsoft.TemplateEngine.Cli.UnitTests\Microsoft.TemplateEngine.Cli.UnitTests.csproj]
2022-08-27T12:39:59.4988966Z D:\a\1\s\src\Tests\Microsoft.TemplateEngine.Cli.UnitTests\ParserTests\UpdateTests.cs(154,50): error CS8604: Possible null reference argument for parameter 'collection' in 'void Assert.Contains<string>(string expected, IEnumerable<string> collection)'. [D:\a\1\s\src\Tests\Microsoft.TemplateEngine.Cli.UnitTests\Microsoft.TemplateEngine.Cli.UnitTests.csproj]
2022-08-27T12:39:59.4991125Z D:\a\1\s\src\Tests\Microsoft.TemplateEngine.Cli.UnitTests\ParserTests\InstallTests.cs(25,27): error CS8604: Possible null reference argument for parameter 'collection' in 'string Assert.Single<string>(IEnumerable<string> collection)'. [D:\a\1\s\src\Tests\Microsoft.TemplateEngine.Cli.UnitTests\Microsoft.TemplateEngine.Cli.UnitTests.csproj]
2022-08-27T12:39:59.4993108Z D:\a\1\s\src\Tests\Microsoft.TemplateEngine.Cli.UnitTests\ParserTests\InstallTests.cs(70,50): error CS8604: Possible null reference argument for parameter 'collection' in 'void Assert.Contains<string>(string expected, IEnumerable<string> collection)'. [D:\a\1\s\src\Tests\Microsoft.TemplateEngine.Cli.UnitTests\Microsoft.TemplateEngine.Cli.UnitTests.csproj]
2022-08-27T12:39:59.6251801Z D:\a\1\s\src\Tests\Microsoft.TemplateEngine.Cli.UnitTests\ParserTests\InstallTests.cs(144,27): error CS8604: Possible null reference argument for parameter 'collection' in 'string Assert.Single<string>(IEnumerable<string> collection)'. [D:\a\1\s\src\Tests\Microsoft.TemplateEngine.Cli.UnitTests\Microsoft.TemplateEngine.Cli.UnitTests.csproj]
2022-08-27T12:39:59.6256410Z D:\a\1\s\src\Tests\Microsoft.TemplateEngine.Cli.UnitTests\ParserTests\InstallTests.cs(194,50): error CS8604: Possible null reference argument for parameter 'collection' in 'void Assert.Contains<string>(string expected, IEnumerable<string> collection)'. [D:\a\1\s\src\Tests\Microsoft.TemplateEngine.Cli.UnitTests\Microsoft.TemplateEngine.Cli.UnitTests.csproj]
2022-08-27T12:39:59.6259564Z D:\a\1\s\src\Tests\Microsoft.TemplateEngine.Cli.UnitTests\ParserTests\ListTests.cs(224,29): error CS8604: Possible null reference argument for parameter 'collection' in 'void Assert.NotEmpty(IEnumerable collection)'. [D:\a\1\s\src\Tests\Microsoft.TemplateEngine.Cli.UnitTests\Microsoft.TemplateEngine.Cli.UnitTests.csproj]
2022-08-27T12:39:59.6266027Z D:\a\1\s\src\Tests\Microsoft.TemplateEngine.Cli.UnitTests\ParserTests\ListTests.cs(228,41): error CS8604: Possible null reference argument for parameter 'collection' in 'void Assert.Contains<string>(string expected, IEnumerable<string> collection)'. [D:\a\1\s\src\Tests\Microsoft.TemplateEngine.Cli.UnitTests\Microsoft.TemplateEngine.Cli.UnitTests.csproj]
2022-08-27T12:39:59.6268766Z D:\a\1\s\src\Tests\Microsoft.TemplateEngine.Cli.UnitTests\ParserTests\SearchTests.cs(223,29): error CS8604: Possible null reference argument for parameter 'collection' in 'void Assert.NotEmpty(IEnumerable collection)'. [D:\a\1\s\src\Tests\Microsoft.TemplateEngine.Cli.UnitTests\Microsoft.TemplateEngine.Cli.UnitTests.csproj]
2022-08-27T12:39:59.6272657Z D:\a\1\s\src\Tests\Microsoft.TemplateEngine.Cli.UnitTests\ParserTests\SearchTests.cs(227,41): error CS8604: Possible null reference argument for parameter 'collection' in 'void Assert.Contains<string>(string expected, IEnumerable<string> collection)'. [D:\a\1\s\src\Tests\Microsoft.TemplateEngine.Cli.UnitTests\Microsoft.TemplateEngine.Cli.UnitTests.csproj]
2022-08-27T12:39:59.6285465Z D:\a\1\s\src\Tests\dotnet.Tests\dotnet-new\DotnetSlnPostActionTests.cs(81,68): error CS8604: Possible null reference argument for parameter 'collection' in 'void Assert.Contains<string>(string expected, IEnumerable<string> collection)'. [D:\a\1\s\src\Tests\dotnet.Tests\dotnet.Tests.csproj]
2022-08-27T12:39:59.6287475Z D:\a\1\s\src\Tests\dotnet.Tests\dotnet-new\DotnetSlnPostActionTests.cs(82,68): error CS8604: Possible null reference argument for parameter 'collection' in 'void Assert.Contains<string>(string expected, IEnumerable<string> collection)'. [D:\a\1\s\src\Tests\dotnet.Tests\dotnet.Tests.csproj]
2022-08-27T12:39:59.6289317Z D:\a\1\s\src\Tests\dotnet.Tests\dotnet-new\DotnetSlnPostActionTests.cs(84,74): error CS8604: Possible null reference argument for parameter 'collection' in 'void Assert.DoesNotContain<string>(string expected, IEnumerable<string> collection)'. [D:\a\1\s\src\Tests\dotnet.Tests\dotnet.Tests.csproj]
2022-08-27T12:39:59.6291188Z D:\a\1\s\src\Tests\dotnet.Tests\dotnet-new\DotnetSlnPostActionTests.cs(132,50): error CS8604: Possible null reference argument for parameter 'collection' in 'void Assert.Contains<string>(string expected, IEnumerable<string> collection)'. [D:\a\1\s\src\Tests\dotnet.Tests\dotnet.Tests.csproj]
2022-08-27T12:39:59.6292973Z D:\a\1\s\src\Tests\dotnet.Tests\dotnet-new\DotnetSlnPostActionTests.cs(133,50): error CS8604: Possible null reference argument for parameter 'collection' in 'void Assert.Contains<string>(string expected, IEnumerable<string> collection)'. [D:\a\1\s\src\Tests\dotnet.Tests\dotnet.Tests.csproj]
2022-08-27T12:39:59.6307420Z D:\a\1\s\src\Tests\dotnet.Tests\dotnet-new\DotnetSlnPostActionTests.cs(135,56): error CS8604: Possible null reference argument for parameter 'collection' in 'void Assert.DoesNotContain<string>(string expected, IEnumerable<string> collection)'. [D:\a\1\s\src\Tests\dotnet.Tests\dotnet.Tests.csproj]
2022-08-27T12:39:59.6310080Z D:\a\1\s\src\Tests\dotnet.Tests\dotnet-new\DotnetSlnPostActionTests.cs(160,50): error CS8604: Possible null reference argument for parameter 'collection' in 'void Assert.Contains<string>(string expected, IEnumerable<string> collection)'. [D:\a\1\s\src\Tests\dotnet.Tests\dotnet.Tests.csproj]
2022-08-27T12:39:59.6316247Z D:\a\1\s\src\Tests\dotnet.Tests\dotnet-new\DotnetSlnPostActionTests.cs(161,50): error CS8604: Possible null reference argument for parameter 'collection' in 'void Assert.Contains<string>(string expected, IEnumerable<string> collection)'. [D:\a\1\s\src\Tests\dotnet.Tests\dotnet.Tests.csproj]

[danmoseley]

I pushed changes to suppress the warnings. I think that's fine because if there are nulls, there'll be a NRE and the test will fail anyway.

I still get one error locally:

C:\git\sdk\src\Layout\redist\targets\OverlaySdkOnLKG.targets(26,5): error : SDK Stage 0 has more than one folder with templates: 7.0.0-preview.5.22303.8;7.0.0-preview.7.22376.6 [C:\git\sdk\src\Layout\redist\redist.csproj]

[danmoseley]

2022-08-29T20:53:01.9113890Z Fail to upload '/Users/runner/work/1/s/artifacts/packages/Release/NonShipping/dotnet-toolset-internal-7.0.100-ci.zip' due to 'Blob is incomplete (missing block). Blob: 037b312fdc27ed1195d7000d3aa4744b, Expected Offset: 0, Actual Offset: 8388608'.
2022-08-29T20:53:01.9118300Z Microsoft.VisualStudio.Services.WebApi.VssServiceResponseException: Blob is incomplete (missing block). Blob: 037b312fdc27ed1195d7000d3aa4744b, Expected Offset: 0, Actual Offset: 8388608
 ---> System.InvalidOperationException: Blob is incomplete (missing block). Blob: 037b312fdc27ed1195d7000d3aa4744b, Expected Offset: 0, Actual Offset: 8388608

[danmoseley]

failed to upload konwn issue. rerunning failed