Skip to content

[8.0 -> 7.0.2 Backport] Make Apps RID Specific By Default & RID Now FDD By Default in 8.0+ #28376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nagilson wants to merge 10 commits into from
Closed

[8.0 -> 7.0.2 Backport] Make Apps RID Specific By Default & RID Now FDD By Default in 8.0+ #28376

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f7e24e9
Add RuntimeSpecific
nagilson Oct 6, 2022
27791d2
Consider that there may not be a target framework
nagilson Oct 7, 2022
08e7eb5
Whoops I didn't see the breaking change spec but this should now make…
nagilson Oct 7, 2022
d182b45
Update xlf
nagilson Oct 7, 2022
04e421b
Add tests, but some are NET 8.0 so they break
nagilson Oct 7, 2022
3d0dc56
Make fact a theory so I can revert then re-revert the 8.0 tests into …
nagilson Oct 7, 2022
bf3d53d
oops wrong framework hahahahaaaaaa
nagilson Oct 7, 2022
7be2640
Meet your demise, 8.0 tests
nagilson Oct 7, 2022
5707dbd
Merge remote-tracking branch 'primary/release/7.0.2xx' into nagilson-…
nagilson Oct 10, 2022
c302992
Update xlf
nagilson Oct 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make fact a theory so I can revert then re-revert the 8.0 tests into … 
…a PR
  • Loading branch information
@nagilson
nagilson committed Oct 7, 2022
commit 3d0dc5636c0335ab50e810a9a95c61ee4ee6e4e6
6 changes: 3 additions & 3 deletions src/Tests/Microsoft.NET.Publish.Tests/RuntimeIdentifiersTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,10 +269,10 @@ public void RuntimeSpecificEnablesOrDisablesRuntimeIdentifierByDefaultBasedOnVal
}
}

[Fact]
public void RuntimeIdentifiersDisablesRuntimeSpecificFDDBehavior()
[Theory]
[InlineData("net7.0")]
public void RuntimeIdentifiersDisablesRuntimeSpecificFDDBehavior(string targetFramework)
{
string targetFramework = "net8.0";
var expectedRuntimeIdentifier = EnvironmentInfo.GetCompatibleRid(targetFramework);
TestAsset testAsset = _testAssetsManager.CreateTestProject(_testProject, identifier: $"RuntimeIdentifierS_{targetFramework}") // the S is intentional to call atention to it
.WithTargetFramework(targetFramework)
Expand Down