Skip to content

Update the sdk build to target net8.0 #28563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nagilson merged 18 commits into from
Nov 21, 2022
Merged

Update the sdk build to target net8.0 #28563

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
d10fd52
Update the sdk build to target net8.0
marcpopMSFT Oct 13, 2022
9f9e5a3
Merge branch 'main' of https://github.com/dotnet/sdk into marcpopMSFT…
Oct 18, 2022
bb646b6
Update global.json
marcpopMSFT Oct 18, 2022
9a467f0
Change the SDK tasks to target 8.0. Update the tests to restore rc2 a…
marcpopMSFT Oct 19, 2022
76c4cf5
Fix two tests broken in the 8.0 update.
marcpopMSFT Oct 25, 2022
e5b252a
Update some more TFM references to 8.0
SteveSandersonMS Oct 27, 2022
17ea857
Another TFM update
SteveSandersonMS Oct 27, 2022
f79b4a7
Merge remote-tracking branch 'origin/main' into marcpopMSFT-updatetfm
marcpopMSFT Nov 7, 2022
38f477d
Update to a newer SDK.
marcpopMSFT Nov 7, 2022
885fa32
Fix the build extensions task location and fix an additional test.
marcpopMSFT Nov 8, 2022
d0badf0
Disable a test affected by another bug.
marcpopMSFT Nov 10, 2022
19ebb6c
Merge branch 'marcpopMSFT-updatetfm' of https://github.com/dotnet/sdk…
marcpopMSFT Nov 10, 2022
4da0821
Update verified content following newly added Playwright templates in…
GangWang01 Nov 14, 2022
9826dfe
[ASP.NET] Remove versions from baselines (#29093)
javiercn Nov 16, 2022
c4deeb3
Update TFMs in some projects and tests
javiercn Nov 18, 2022
6bc8daf
Avoid potential NRE (#29128)
tmat Nov 18, 2022
7783633
Merge branch 'marcpopMSFT-updatetfm' of https://github.com/dotnet/sdk…
marcpopMSFT Nov 18, 2022
923d9f5
Merge branch 'main' into marcpopMSFT-updatetfm
nagilson Nov 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Disable a test affected by another bug. 
Fix our implicit defines behavior for the windows platform versions
  • Loading branch information
@marcpopMSFT
marcpopMSFT committed Nov 10, 2022
commit d0badf0d707ada724d635de135a5ded8fd5bbf41
2 changes: 1 addition & 1 deletion src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.BeforeCommon.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ Copyright (c) .NET Foundation. All rights reserved.
Condition=" '$(DisableImplicitFrameworkDefines)' != 'true' and '$(TargetPlatformIdentifier)' != '' and '$(TargetFrameworkIdentifier)' == '.NETCoreApp' and $([MSBuild]::VersionGreaterThanOrEquals($(TargetFrameworkVersion), 5.0)) " >
<ItemGroup>
<_SupportedPlatformCompatibleVersions Include="@(SdkSupportedTargetPlatformVersion)" Condition=" %(Identity) != '' and $([MSBuild]::VersionLessThanOrEquals(%(Identity), $(TargetPlatformVersion))) " />
<_ImplicitDefineConstant Include="@(_SupportedPlatformCompatibleVersions->'$(TargetPlatformIdentifier.ToUpper())%(Identity)_OR_GREATER'->Replace('.', '_'))" />
<_ImplicitDefineConstant Include="@(_SupportedPlatformCompatibleVersions->Distinct()->'$(TargetPlatformIdentifier.ToUpper())%(Identity)_OR_GREATER'->Replace('.', '_'))" />
</ItemGroup>
</Target>

Expand Down
2 changes: 1 addition & 1 deletion src/Tests/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildAWindowsDesktopProject.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ public void It_fails_if_windows_target_platform_version_is_invalid()
.HaveStdOutContaining("NETSDK1140");
}

[WindowsOnlyTheory]
[WindowsOnlyTheory(Skip="https://github.com/dotnet/sdk/pull/29009")]
[InlineData(true)]
[InlineData(false)]
public void It_succeeds_if_windows_target_platform_version_does_not_have_trailing_zeros(bool setInTargetframework)
Expand Down