Skip to content

[main] Update dependencies from dotnet/runtime #28865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jeffschwMSFT merged 6 commits into from
Nov 8, 2022
Merged

[main] Update dependencies from dotnet/runtime #28865

jeffschwMSFT merged 6 commits into from
Nov 8, 2022

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Nov 3, 2022 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

  • Subscription: aa69f164-2492-460a-3914-08d8e9750bf8
  • Build: 20221107.12
  • Date Produced: November 8, 2022 10:24:47 AM UTC
  • Commit: af841c8b33cecc92d74222298f1e45bf7bf3d90a
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2022…
c6fb795 
…1102.12

Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0
 From Version 8.0.0-alpha.1.22551.9 -> To Version 8.0.0-alpha.1.22552.12
@ghost ghost added the Area-CodeFlow label Nov 3, 2022
@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Nov 3, 2022

Notification for subscribed users from https://github.com/dotnet/runtime:

@dnr-codeflow

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

  • This pull request contains changes from your source repo (https://github.com/dotnet/runtime) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
  • If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
  • For more details, please read the Arcade Darc documentation

@jeffschwMSFT
Copy link
Member

jeffschwMSFT commented Nov 3, 2022

@agocke all the builds are broken with something like the following...

Assembly 'Microsoft.Extensions.DependencyModel' with identity 'Microsoft.Extensions.DependencyModel, Version=8.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60' uses 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' which has a higher version than referenced assembly 'System.Runtime' with identity 'System.Runtime, Version=7.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'

Was a 7 input being confused for 8? Can you take a look?

@agocke
Copy link
Member

agocke commented Nov 3, 2022

Looking. Not sure what could possible cause this wide of a break.

@agocke
Copy link
Member

agocke commented Nov 3, 2022 •
edited
Loading

OK, I think this is a real product break. @ViktorHofer any suggestions on who could help on the libraries team?

I think the issue here is that there's been a major version bump of some components, but not a TFM bump in certain areas. What I'm seeing with Microsoft.Extensions.DependencyModel is that the new version is 8.0, which is fine, but it references framework dependencies that are also 8.0, and it's in the net7.0 directory. I think that's wrong.

Right now when we try to build in the SDK we're building for net7.0, so we grab the latest binaries for net7.0, but still use the framework as provided by global.json. That means we're compiling using the net7.0 RC framework. If new packages aren't compatible with those binaries, they will break, and I think that's correct. We shouldn't be doing things like major version bumps without also bumping the TFM.

@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2022…
b4652ef 
…1104.1

Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0
 From Version 8.0.0-alpha.1.22551.9 -> To Version 8.0.0-alpha.1.22554.1
@jeffschwMSFT
Copy link
Member

jeffschwMSFT commented Nov 4, 2022

adding @ericstj as well

@ViktorHofer
Copy link
Member

ViktorHofer commented Nov 4, 2022

OK, I think this is a real product break. @ViktorHofer any suggestions on who could help on the libraries team?

cc @carlossanlop who authored the assembly version change

Here's The work item that tracks updating dotnet/runtime to .NET 8. When I did the same work last year, I combined everything into a single PR. We wanted to split the work into separate changes this time, to make it easier to review them.

Assembly 'Microsoft.Extensions.DependencyModel' with identity 'Microsoft.Extensions.DependencyModel, Version=8.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60' uses 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' which has a higher version than referenced assembly 'System.Runtime' with identity 'System.Runtime, Version=7.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'

I haven't yet looked at the build failures, but the above error tells me that something still references the 7.0.0.0 version of System.Runtime.

@ViktorHofer
Copy link
Member

ViktorHofer commented Nov 4, 2022

Spoke with @ericstj about this offline and we will revert the assembly version change for now in runtime until we have the tfm update ready.

@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2022…
44cd3a4 
…1104.7

Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0
 From Version 8.0.0-alpha.1.22551.9 -> To Version 8.0.0-alpha.1.22554.7
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2022…
342f3ba 
…1105.3

Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0
 From Version 8.0.0-alpha.1.22551.9 -> To Version 8.0.0-alpha.1.22555.3
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2022…
6d840e1 
…1106.2

Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0
 From Version 8.0.0-alpha.1.22551.9 -> To Version 8.0.0-alpha.1.22556.2
@jeffschwMSFT
Copy link
Member

jeffschwMSFT commented Nov 7, 2022

@ViktorHofer @ericstj @carlossanlop can we get an update on our plan to revert the versioning change? Thanks

@ViktorHofer
Copy link
Member

ViktorHofer commented Nov 7, 2022

@ViktorHofer @ericstj @carlossanlop can we get an update on our plan to revert the versioning change? Thanks

Here's the revert PR: dotnet/runtime#77899. Based on the latest information in the thread, I'm unsure if it can already be merged or not. cc @radical

@carlossanlop
Copy link
Contributor

carlossanlop commented Nov 7, 2022

Here's the revert PR: dotnet/runtime#77899. Based on the latest information in the thread, I'm unsure if it can already be merged or not. cc @radical

@ViktorHofer I merged it to unblock the other teams. @radical is OOF this week so I pinged @lewing and @steveisok for help with the additional WASM problem. Fortunately, all of the necessary infra changes in WASM were included in the original PR, so we're reverting them all together.

@JanKrivanek JanKrivanek mentioned this pull request Nov 8, 2022
Merged
2 tasks
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2022…
35e5375 
…1107.12

Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0
 From Version 8.0.0-alpha.1.22551.9 -> To Version 8.0.0-alpha.1.22557.12
@jeffschwMSFT
Copy link
Member

jeffschwMSFT commented Nov 8, 2022

Rerunning due to ephemeral error:

.dotnet\sdk\7.0.100-rc.1.22431.12\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Publish.targets(248,5): error MSB3030: Could not copy the file "D:\a\_work\1\s\src\Assets\TestPackages\PackageWithFakeNativeDep\obj\188a6755-c78f-4012-9da3-a268d08e8d2a.tmp" because it was not found.

jeffschwMSFT
jeffschwMSFT approved these changes Nov 8, 2022
View reviewed changes
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jeffschwMSFT jeffschwMSFT merged commit c6b5899 into main Nov 8, 2022
@jeffschwMSFT jeffschwMSFT deleted the darc-main-8ff7ff37-43bb-48fe-9714-370915c01986 branch November 8, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeffschwMSFT jeffschwMSFT jeffschwMSFT approved these changes

Assignees

No one assigned

Labels

Area-CodeFlow

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jeffschwMSFT @agocke @ViktorHofer @carlossanlop