Clean up Razor Server pid file if the path doesn't exist #29029
Merged
+59
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the server path in the pid file didn't exist we'd hit an error: ``` The shutdown command failed: The application to execute does not exist ``` This can happen when the file wasn't cleaned up and the SDK was uninstalled in the meantime. Ensure we delete the pid file in that case and don't error. Fixes dotnet#10573
ghost
added
the
dsplaisted
approved these changes
Nov 14, 2022
akoeplinger
added a commit
to akoeplinger/sdk
that referenced
this pull request
Nov 17, 2022
While debugging dotnet#29029 I noticed that we hit an unhandled exception because later macOS versions don't have an extra dot in the RID version number so the string split failed. Switched to using float parsing for the version like we do for Ubuntu.
akoeplinger
added a commit
to akoeplinger/sdk
that referenced
this pull request
Nov 21, 2022
While debugging dotnet#29029 I noticed that we hit an unhandled exception because later macOS versions don't have an extra dot in the RID version number so the string split failed. Switched to using float parsing for the version like we do for Ubuntu.
marcpopMSFT
pushed a commit
that referenced
this pull request
Jan 20, 2023
While debugging #29029 I noticed that we hit an unhandled exception because later macOS versions don't have an extra dot in the RID version number so the string split failed. Switched to using float parsing for the version like we do for Ubuntu.
dsplaisted
pushed a commit
to dsplaisted/sdk
that referenced
this pull request
Jan 31, 2023
While debugging dotnet#29029 I noticed that we hit an unhandled exception because later macOS versions don't have an extra dot in the RID version number so the string split failed. Switched to using float parsing for the version like we do for Ubuntu.
dsplaisted
pushed a commit
to dsplaisted/sdk
that referenced
this pull request
Jan 31, 2023
While debugging dotnet#29029 I noticed that we hit an unhandled exception because later macOS versions don't have an extra dot in the RID version number so the string split failed. Switched to using float parsing for the version like we do for Ubuntu.
marcpopMSFT
pushed a commit
that referenced
this pull request
Feb 7, 2023
While debugging #29029 I noticed that we hit an unhandled exception because later macOS versions don't have an extra dot in the RID version number so the string split failed. Switched to using float parsing for the version like we do for Ubuntu.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the server path in the pid file didn't exist we'd hit an error during
dotnet build-server shutdown:This can happen when the file wasn't cleaned up and the SDK was uninstalled in the meantime. Ensure we delete the pid file in that case and don't error.
Fixes #10573