Skip to content

[main] Update dependencies from dotnet/runtime #29121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dotnet-maestro merged 4 commits into from
Nov 21, 2022
Merged

[main] Update dependencies from dotnet/runtime #29121

dotnet-maestro merged 4 commits into from
Nov 21, 2022

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Nov 18, 2022 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

  • Subscription: aa69f164-2492-460a-3914-08d8e9750bf8
  • Build: 20221120.4
  • Date Produced: November 21, 2022 7:36:53 AM UTC
  • Commit: 9129083c2fc6ef32479168f0555875b54aee4dfb
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2022…
0927278 
…1117.5

Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0
 From Version 8.0.0-alpha.1.22559.2 -> To Version 8.0.0-alpha.1.22567.5
@ghost ghost added the Area-CodeFlow label Nov 18, 2022
@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Nov 18, 2022

Notification for subscribed users from https://github.com/dotnet/runtime:

@dnr-codeflow

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

  • This pull request contains changes from your source repo (https://github.com/dotnet/runtime) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
  • If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
  • For more details, please read the Arcade Darc documentation

@eerhardt eerhardt mentioned this pull request Nov 18, 2022
Closed
@eerhardt
Copy link
Member

eerhardt commented Nov 18, 2022

dotnet watch tests appear to be failing for the same reason as #29085.

See https://helix.dot.net/api/2019-06-17/jobs/a042e8df-e910-4d4e-b60e-9f4d08a75a79/workitems/dotnet-watch.Tests.dll.1/console

Process ID: 249
    Microsoft.DotNet.Watcher.Tools.BrowserLaunchTests.UsesBrowserSpecifiedInEnvironment [FAIL]
�[31;1m�[m�[37m      Assert.StartsWith() Failure:
�[m�[37m      Expected: dotnet watch ⌚ Launching browser: mycustombrowser.bat https://localhost:5001/
�[m�[37m      Actual:   (null)
�[m�[30;1m      Stack Trace:
�[m�[37m        /_/src/Tests/dotnet-watch.Tests/Utilities/WatchableApp.cs(57,0): at Microsoft.DotNet.Watcher.Tools.WatchableApp.AssertOutputLineStartsWith(String expectedPrefix)
�[m�[37m        /_/src/Tests/dotnet-watch.Tests/BrowserLaunchTests.cs(60,0): at Microsoft.DotNet.Watcher.Tools.BrowserLaunchTests.UsesBrowserSpecifiedInEnvironment()
�[m�[37m        --- End of stack trace from previous location ---
�[m�[30;1m      Output:
�[m�[37m        > /root/helix/work/correlation/d/dotnet msbuild /t:Build /root/helix/work/workitem/e/testExecutionDirectory/UsesBrowserSp---002AD626_2/WatchBrowserLaunchApp.csproj /restore
�[m�[37m        MSBuild version 17.5.0-preview-22564-01+d14b74d6f for .NET
�[m�[37m          Determining projects to restore...
�[m�[37m          Restored /root/helix/work/workitem/e/testExecutionDirectory/UsesBrowserSp---002AD626_2/WatchBrowserLaunchApp.csproj (in 148 ms).
�[m�[37m        /root/helix/work/correlation/d/sdk/8.0.100-ci/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.RuntimeIdentifierInference.targets(275,5): message NETSDK1057: You are using a preview version of .NET. See: https://aka.ms/dotnet-support-policy [/root/helix/work/workitem/e/testExecutionDirectory/UsesBrowserSp---002AD626_2/WatchBrowserLaunchApp.csproj]
�[m�[37m          WatchBrowserLaunchApp -> /root/helix/work/workitem/e/testExecutionDirectory/UsesBrowserSp---002AD626_2/bin/Debug/net7.0/WatchBrowserLaunchApp.dll
�[m�[37m        11/18/2022 1:47:14 PM: starting process: '/root/helix/work/correlation/d/dotnet watch --verbose run --'
�[m�[37m        11/18/2022 1:47:14 PM: process started: '/root/helix/work/correlation/d/dotnet watch --verbose run --'
�[m�[37m        11/18/2022 1:47:14 PM: post: 'dotnet watch ⌚ Polling file watcher is enabled'
�[m�[37m        11/18/2022 1:47:15 PM: post: 'dotnet watch ⌚ Project supports hot reload and was configured to run with the default run-command. Watching with hot-reload'
�[m�[37m        11/18/2022 1:47:15 PM: post: 'dotnet watch 🔥 Hot reload enabled. For a list of supported edits, see https://aka.ms/dotnet/hot-reload.'
�[m�[37m        11/18/2022 1:47:15 PM: post: '  💡 Press "Ctrl + R" to restart.'
�[m�[37m        11/18/2022 1:47:15 PM: post: 'dotnet watch 🔧 Building...'
�[m�[37m        11/18/2022 1:47:15 PM: post: 'dotnet watch 🚀 Started '/root/helix/work/correlation/d/dotnet' 'msbuild /t:Build /restore /nologo' with process id 294'
�[m�[37m        11/18/2022 1:47:16 PM: post: '  Determining projects to restore...'
�[m�[37m        11/18/2022 1:47:16 PM: post: '  All projects are up-to-date for restore.'
�[m�[37m        11/18/2022 1:47:16 PM: post: '/root/helix/work/correlation/d/sdk/8.0.100-ci/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.RuntimeIdentifierInference.targets(275,5): message NETSDK1057: You are using a preview version of .NET. See: https://aka.ms/dotnet-support-policy [/root/helix/work/workitem/e/testExecutionDirectory/UsesBrowserSp---002AD626_2/WatchBrowserLaunchApp.csproj]'
�[m�[37m        11/18/2022 1:47:17 PM: post: '  WatchBrowserLaunchApp -> /root/helix/work/workitem/e/testExecutionDirectory/UsesBrowserSp---002AD626_2/bin/Debug/net7.0/WatchBrowserLaunchApp.dll'
�[m�[37m        11/18/2022 1:47:17 PM: post: 'dotnet watch ⌚ Process id 294 ran for 1876ms'
�[m�[37m        11/18/2022 1:47:17 PM: post: 'dotnet watch ⌚ Running MSBuild target 'GenerateWatchList' on '/root/helix/work/workitem/e/testExecutionDirectory/UsesBrowserSp---002AD626_2/WatchBrowserLaunchApp.csproj''
�[m�[37m        11/18/2022 1:47:17 PM: post: 'dotnet watch 🚀 Started '/root/helix/work/correlation/d/dotnet' 'msbuild /nologo /root/helix/work/workitem/e/testExecutionDirectory/UsesBrowserSp---002AD626_2/WatchBrowserLaunchApp.csproj /p:_DotNetWatchListFile=/tmp/tmpznYIjP.tmp /nologo /v:n /t:GenerateWatchList /p:DotNetWatchBuild=true /p:DesignTimeBuild=true /p:CustomAfterMicrosoftCommonTargets=/root/helix/work/correlation/d/sdk/8.0.100-ci/DotnetTools/dotnet-watch/8.0.100-ci/tools/net7.0/any/DotNetWatch.targets /p:CustomAfterMicrosoftCommonCrossTargetingTargets=/root/helix/work/correlation/d/sdk/8.0.100-ci/DotnetTools/dotnet-watch/8.0.100-ci/tools/net7.0/any/DotNetWatch.targets' with process id 317'
�[m�[37m        11/18/2022 1:47:18 PM: post: 'dotnet watch ⌚ Process id 317 ran for 934ms'
�[m�[37m        11/18/2022 1:47:18 PM: post: 'dotnet watch ⌚ Watching 2 file(s) for changes'
�[m�[37m        11/18/2022 1:47:18 PM: post: 'dotnet watch ⌚ dotnet-watch is configured to launch a browser on ASP.NET Core application startup.'
�[m�[37m        11/18/2022 1:47:18 PM: post: 'dotnet watch ⌚ Skipping configuring browser-refresh middleware since this is not a webapp.'
�[m�[37m        11/18/2022 1:47:18 PM: post: 'dotnet watch ❌ System.NullReferenceException: Object reference not set to an instance of an object.'
�[m�[37m        11/18/2022 1:47:18 PM: post: '   at Microsoft.DotNet.Cli.EnvironmentVariableNames.TryParseArchitecture(String runtimeIdentifier, Architecture& architecture) in /_/src/Common/EnvironmentVariableNames.cs:line 57'
�[m�[37m        11/18/2022 1:47:18 PM: post: '   at Microsoft.DotNet.Cli.EnvironmentVariableNames.TryGetDotNetRootVariableNameImpl(String runtimeIdentifier, String defaultAppHostRuntimeIdentifier, Version targetFrameworkVersion, Architecture currentArchitecture, Boolean is64bit) in /_/src/Common/EnvironmentVariableNames.cs:line 39'
�[m�[37m        11/18/2022 1:47:18 PM: post: '   at Microsoft.DotNet.Cli.EnvironmentVariableNames.TryGetDotNetRootVariableName(String runtimeIdentifier, String defaultAppHostRuntimeIdentifier, Version targetFrameworkVersion) in /_/src/Common/EnvironmentVariableNames.cs:line 32'
�[m�[37m        11/18/2022 1:47:18 PM: post: '   at Microsoft.DotNet.Watcher.HotReloadDotNetWatcher.ConfigureExecutable(DotNetWatchContext context, ProcessSpec processSpec) in /_/src/BuiltInTools/dotnet-watch/HotReloadDotNetWatcher.cs:line 311'
�[m�[37m        11/18/2022 1:47:18 PM: post: '   at Microsoft.DotNet.Watcher.HotReloadDotNetWatcher.WatchAsync(DotNetWatchContext context, CancellationToken cancellationToken) in /_/src/BuiltInTools/dotnet-watch/HotReloadDotNetWatcher.cs:line 116'
�[m�[37m        11/18/2022 1:47:18 PM: post: '   at Microsoft.DotNet.Watcher.Program.MainInternalAsync(CommandLineOptions options, CancellationToken cancellationToken) in /_/src/BuiltInTools/dotnet-watch/Program.cs:line 306'
�[m�[37m        11/18/2022 1:47:18 PM: post: '   at Microsoft.DotNet.Watcher.Program.MainInternalAsync(CommandLineOptions options, CancellationToken cancellationToken) in /_/src/BuiltInTools/dotnet-watch/Program.cs:line 306'
�[m�[37m        11/18/2022 1:47:18 PM: post: '   at Microsoft.DotNet.Watcher.Program.HandleWatch(CommandLineOptions options) in /_/src/BuiltInTools/dotnet-watch/Program.cs:line 201'
�[m�[37m        11/18/2022 1:47:18 PM: post: 'dotnet watch ❌ An unexpected error occurred'
�[m�[37m        11/18/2022 1:47:18 PM: post: ''
�[m�[37m        11/18/2022 1:47:18 PM: post: ''
�[m�[37m        Process 271 has exited
�[m�[37m        Disposing WatchableApp

@eerhardt
Copy link
Member

eerhardt commented Nov 18, 2022

@tmat - this looks to be caused by e250cd7. Can you take a look?

@nagilson
Copy link
Member

nagilson commented Nov 18, 2022

Indeed, this is the same as #29099

@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2022…
ddfa1e5 
…1118.10

Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0
 From Version 8.0.0-alpha.1.22559.2 -> To Version 8.0.0-alpha.1.22568.10
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2022…
c8f6715 
…1119.4

Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0
 From Version 8.0.0-alpha.1.22559.2 -> To Version 8.0.0-alpha.1.22569.4
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2022…
253f720 
…1120.4

Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0
 From Version 8.0.0-alpha.1.22559.2 -> To Version 8.0.0-alpha.1.22570.4
@dotnet-maestro dotnet-maestro bot merged commit 856940f into main Nov 21, 2022
@dotnet-maestro dotnet-maestro bot deleted the darc-main-03e58bb0-09fa-4079-af9e-644ef419eb85 branch November 21, 2022 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marek-safar marek-safar marek-safar approved these changes

Assignees

No one assigned

Labels

Area-CodeFlow

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eerhardt @nagilson @marek-safar