Make the code build before finishing tests

src/Cli/dotnet/ReleasePropertyProjectLocator.cs

@@ -50,6 +50,7 @@ string propertyToCheck
         public IEnumerable<string> GetCustomDefaultConfigurationValueIfSpecified()
         {
             // Setup
+#nullable enable
             Debug.Assert(_propertyToCheck == MSBuildPropertyNames.PUBLISH_RELEASE || _propertyToCheck == MSBuildPropertyNames.PACK_RELEASE, "Only PackRelease or PublishRelease are currently expected.");
             var nothing = Enumerable.Empty<string>();
             if (String.Equals(Environment.GetEnvironmentVariable(EnvironmentVariableNames.DISABLE_PUBLISH_AND_PACK_RELEASE), "true", StringComparison.OrdinalIgnoreCase))
@@ -67,7 +68,7 @@ public IEnumerable<string> GetCustomDefaultConfigurationValueIfSpecified()
                 return nothing;
 
             // Determine the project being acted upon
-            ProjectInstance project = GetTargetedProject(globalProperties);
+            ProjectInstance? project = GetTargetedProject(globalProperties);
 
             // Determine the correct value to return
             if (project != null)
@@ -118,7 +119,7 @@ public IEnumerable<string> GetCustomDefaultConfigurationValueIfSpecified()
                     }
                     catch (GracefulException)  // Fall back to looking for a solution if multiple project files are found, or there's no project in the directory.
                     {
-                        string potentialSln = Directory.GetFiles(arg, "*.sln", SearchOption.TopDirectoryOnly).FirstOrDefault();
+                        string? potentialSln = Directory.GetFiles(arg, "*.sln", SearchOption.TopDirectoryOnly).FirstOrDefault();
 
                         if (!string.IsNullOrEmpty(potentialSln))
                         {
@@ -171,6 +172,7 @@ public IEnumerable<string> GetCustomDefaultConfigurationValueIfSpecified()
                 Reporter.Error.WriteLine(e.Message);
             }
             return null;
+#nullable disable
         }
 
         /// <returns>Returns true if the path exists and is a project file type.</returns> 

src/Tests/Microsoft.NET.Publish.Tests/GivenThatWeWantToTestAMultitargetedSolutionWithPublishReleaseOrPackRelease.cs

@@ -63,7 +63,6 @@ internal Tuple<TestSolution, List<TestProject>> Setup(ITestOutputHelper log, str
         }
 
 
-        [InlineData("PackRelease")]
         [InlineData("PublishRelease")]
         [Theory]
         public void ItUsesReleaseWithNet8PlusAndNet7WhereNoneDefineTheReleaseProperty(string releaseProperty)
@@ -101,97 +100,109 @@ public void ItWorksWithASpecificSolutionPathGiven()
 
         }
 
+        [InlineData("-f netx.0")]
+        [InlineData("-p:TargetFramework=netx.0")]
         [Theory]
-        public void ItPublishesReleaseWithATargetFrameworkOptionNet8ForNet6AndNet7MultitargetingProjectWithPublishReleaseUndefined
+        public void ItPublishesReleaseWithATargetFrameworkOptionNet8ForNet6AndNet7MultitargetingProjectWithPublishReleaseUndefined(string args)
         {
-        // property and option theory
-
+            Console.WriteLine(args);
         }
 
+        [InlineData("-f netx.0")]
+        [InlineData("-p:TargetFramework=netx.0")]
         [Theory]
-        public void ItPublishesDebugWithATargetFrameworkOptionNet7ForNet8Net7ProjectAndNet7Net6ProjectSolutionWithPublishReleaseUndefined
+        public void ItPublishesDebugWithATargetFrameworkOptionNet7ForNet8Net7ProjectAndNet7Net6ProjectSolutionWithPublishReleaseUndefined(string args)
         {
-        // property and option theory
-
+            Console.WriteLine(args);
         }
 
         [Fact]
-        public void ItPacksDebugWithMutlitargetingWhereNet8AndNet7ProjectDefinePackReleaseFalse
+        public void ItPacksDebugWithMutlitargetingWhereNet8AndNet7ProjectDefinePackReleaseFalse()
         {
 
         }
 
         [Fact]
-        public void ItPacksDebugWithSolutionWithNet8ProjectAndNet8tNet6ProjectThatDefinePackReleaseFalse
+        public void ItPacksDebugWithSolutionWithNet8ProjectAndNet8tNet6ProjectThatDefinePackReleaseFalse()
         {
 
         }
 
         [Fact]
-        public void ItFailsToPackWithMultiProjectSolutionWithConflictingPackRelease
+        public void ItFailsToPackWithMultiProjectSolutionWithConflictingPackRelease()
         {
 
         }
 
         [Fact]
-        public void ItPacksReleaseWithANet8ProjectAndNet7ProjectSolutionWherePackReleaseUndefined
+        public void ItPacksReleaseWithANet8ProjectAndNet7ProjectSolutionWherePackReleaseUndefined()
         {
 
         }
 
         [Fact]
-        public void ItPacksReleaseWithNet8Net7MultitargetProjectWithPackReleaseUndefined
+        public void ItPacksReleaseWithNet8Net7MultitargetProjectWithPackReleaseUndefined()
         {
 
         }
 
+        [InlineData("PackRelease")]
+        [InlineData("PublishRelease")]
         [Theory]
-        public void ItDoesntErrorIfEnvironmentVariableOptOutEnabledButReleaseConflicts
+        public void ItDoesntErrorIfEnvironmentVariableOptOutEnabledButReleaseConflicts(string releaseProperty)
         {
-            // publish and pack theory
+            Console.WriteLine(releaseProperty);
         }
 
+        [InlineData("PackRelease")]
+        [InlineData("PublishRelease")]
         [Theory]
-        public void ItDoesntErrorIfReleaseConflictsInVisualStudio
+        public void ItDoesntErrorIfReleaseConflictsInVisualStudio(string releaseProperty)
         {
-            // publish and pack theory
+            Console.WriteLine(releaseProperty);
 
         }
 
         [Fact]
-        public void ItPublishesWithReleaseWhenNet8ProjectWithNothingAndNet7ProjectWithPublishReleaseDefinitionUsed
+        public void ItPublishesWithReleaseWhenNet8ProjectWithNothingAndNet7ProjectWithPublishReleaseDefinitionUsed()
         {
 
         }
 
+        [InlineData("true")]
+        [InlineData("false")]
         [Theory]
-        public void ItFailsWhenNet8ProjectWithPublishReleaseDefinedButNet7ProjectDoesNotDefine
+        public void ItFailsWhenNet8ProjectWithPublishReleaseDefinedButNet7ProjectDoesNotDefine(string publishReleaseValue)
         {
-            // true and false theory
-        }   
+            Console.WriteLine(publishReleaseValue);
+
+        }
 
 
         [Fact]
-        public void ItDoesNotErrorWhenNet7AndNet6ProjectDontDefinePublishRelease
+        public void ItDoesNotErrorWhenNet7AndNet6ProjectDontDefinePublishRelease()
         {
 
         }
 
+        [InlineData("true")]
+        [InlineData("false")]
+        [InlineData("")]
         [Theory]
-        public void ItFailsWithNet8ProjectAndNet7ProjectSolutionWithPublishReleaseUndefined
+        public void ItFailsWithNet8ProjectAndNet7ProjectSolutionWithPublishReleaseUndefined(string publishReleaseValue)
         {
-            // net 8 defines publishrelease none, true and false
+            Console.WriteLine(publishReleaseValue);
 
         }
 
         [Fact]
-        public void ItFailsIfNet7DefinesPublishReleaseFalseButNet8PlusDefinesNone
+        public void ItFailsIfNet7DefinesPublishReleaseFalseButNet8PlusDefinesNone()
         {
 
         }
 
         [Fact]
-        public void ItPublishesReleaseIfNet7DefinesPublishReleaseTrueNet8PlusDfinesNothing
+        public void ItPublishesReleaseIfNet7DefinesPublishReleaseTrueNet8PlusDfinesNothing()
         {
 
         }