Skip to content

Re-enable single-file tests #29872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elinor-fung merged 1 commit into from
Jan 12, 2023
Merged

Re-enable single-file tests #29872

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions src/Tests/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishASingleFileApp.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ private DirectoryInfo GetPublishDirectory(PublishCommand publishCommand, string
runtimeIdentifier: RuntimeInformation.RuntimeIdentifier);
}

[Fact(Skip = "https://github.com/dotnet/sdk/issues/29602")]
[Fact]
public void Incremental_add_single_file()
{
var testProject = new TestProject()
Expand Down Expand Up @@ -678,10 +678,9 @@ static void ProduceLinkerAnalysisWarning()
[InlineData(ToolsetInfo.CurrentTargetFramework, false, IncludeDefault)]
[InlineData(ToolsetInfo.CurrentTargetFramework, false, IncludeNative)]
[InlineData(ToolsetInfo.CurrentTargetFramework, false, IncludeAllContent)]
// https://github.com/dotnet/sdk/issues/29602
//[InlineData(ToolsetInfo.CurrentTargetFramework, true, IncludeDefault)]
//[InlineData(ToolsetInfo.CurrentTargetFramework, true, IncludeNative)]
//[InlineData(ToolsetInfo.CurrentTargetFramework, true, IncludeAllContent)]
[InlineData(ToolsetInfo.CurrentTargetFramework, true, IncludeDefault)]
[InlineData(ToolsetInfo.CurrentTargetFramework, true, IncludeNative)]
[InlineData(ToolsetInfo.CurrentTargetFramework, true, IncludeAllContent)]
public void It_runs_single_file_apps(string targetFramework, bool selfContained, string bundleOption)
{
var testProject = new TestProject()
Expand Down Expand Up @@ -842,7 +841,7 @@ public void It_does_not_compress_single_file_by_default()
uncompressedSize.Should().Be(compressedSize);
}

[Fact(Skip = "https://github.com/dotnet/sdk/issues/29602")]
[RequiresMSBuildVersionFact("17.0.0.32901")]
public void User_can_get_bundle_info_before_bundling()
{
var testProject = new TestProject()
Expand Down