Skip to content

Convert ComHost tasks to use System.Text.Json instead of Newtonsoft.Json #3087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Convert ComHost tasks to use System.Text.Json instead of Newtonsoft.Json #3087

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f7f53dc
Add reference to Microsoft.Bcl.Json.Sources source package.
jkoritzinsky Apr 4, 2019
ed58b77
Convert reg-free com manifest generation to System.Text.Json.
jkoritzinsky Apr 5, 2019
b781924
Move ComHost tasks over to System.Text.Json.
jkoritzinsky Apr 5, 2019
1f5ef15
Add TODO remove comment.
jkoritzinsky Apr 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add TODO remove comment.
  • Loading branch information
@jkoritzinsky
jkoritzinsky committed Apr 5, 2019
commit 1f5ef158227c40f9e5542dd8b4145bc9d48e04f7
1 change: 1 addition & 0 deletions src/Tasks/Microsoft.NET.Build.Tasks/ArrayBufferWriter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ namespace Microsoft.NET.Build.Tasks
{
/// <summary>
/// Implementation of System.Buffers.IBufferWriter backed by ArrayPool.Shared.
/// TODO Remove once we have https://github.com/dotnet/corefx/issues/34894
/// </summary>
internal class ArrayBufferWriter : IBufferWriter<byte>, IDisposable
Copy link

@wli3 wli3 Apr 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a comment like // TODO Remove once we have https://github.com/dotnet/corefx/issues/34894

Copy link
Contributor

@nguerrera nguerrera Apr 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, spreading this to every repo is getting silly. Let's wait for it to be in. I don't understand the rush to use this API. Particularly because we can't actually remove N.J until NuGet does.

{
Expand Down