Add support for new output path format #31454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roperty, and reenable pack tests
ghost
added
the
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
dsplaisted
force-pushed
the
artifacts-output-paths-main
branch
from
cabfdfe to
b9b67fb
Compare
javiercn
approved these changes
Mar 27, 2023
Member
javiercn
left a comment
javiercn
left a comment
There was a problem hiding this comment.
Changes from the ASP.NET Core perspective look good. Let us know if you need further input from our side
nagilson
approved these changes
Mar 30, 2023
Member
nagilson
left a comment
nagilson
left a comment
There was a problem hiding this comment.
The port and solution consolidation looks great to me. Thank you for consolidating those. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports the artifacts output support from #29599 to main. This implements the design in dotnet/designs#281.
In addition to porting the code, it also includes the following:
ArtifactsPathcalculation logic by adding a .props file which can be imported from two different places depending on whether there are any artifacts output properties set in Directory.Build.props (or the command line) or not.Still to do:
Directory.Build.propsimport, and use that in SDK instead of duplicate import logic.