Enable interceptors feature when ConfigurationBindingGenerator is enabled #35045
+24
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Thanks for your PR, @layomia. |
tarekgh
approved these changes
Aug 30, 2023
captainsafia
approved these changes
Aug 30, 2023
jeffhandley
approved these changes
Aug 30, 2023
Member
jeffhandley
left a comment
jeffhandley
left a comment
There was a problem hiding this comment.
LGTM. I defer to @marcpopMSFT on merging into this repo.
eerhardt
approved these changes
Aug 30, 2023
Member
|
Merging to get into rc2 and onwards. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting #34840 to RC-2. Ideally should be merged to RC-2 before #35024, so that git history shows the right progression of the feature & to include the unit test for config binding.