Remove SelfContained set to false for -a #35286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ogram.cs file requires this project reference to build.
…d tests based on the removal of the property.
ghost
added
Member
|
@MiYanni the CLA check is stuck - good to go whenever you can get that check green. |
nagilson
reviewed
Sep 12, 2023
Member
nagilson
left a comment
nagilson
left a comment
There was a problem hiding this comment.
LGTM, but make sure to update the breaking change documents as well. Thank you for helping make this change! :)
Member
|
Ah jk it's already here dotnet/docs#37058 |
Member
Author
Thanks @nagilson and @baronfel for the breaking change issue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #34026
Summary
When using
-a, we were forcingSelfContainedto be set tofalse. This is considered a breaking change, but the current functionality isn't desired. So, we change that here to no longer update theSelfContainedproperty.Details
This change is thematically the same as #30038.
-asets the RID and we changed RID handling to no longer update theSelfContainedproperty totrue. Here in this situation, it was doing the same but changing it tofalseinstead. This was only specific to the-aoption unlike the other set of changes.