Skip to content

Add workload config command #39888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsplaisted merged 9 commits into from
Apr 4, 2024
Merged

Add workload config command #39888

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
90cd2f5
Show workload version even if no workload set is installed
dsplaisted Mar 18, 2024
ae68813
Move VM testing framework to subfolder
dsplaisted Mar 18, 2024
56efa35
Add workload config command
dsplaisted Mar 19, 2024
321b6d4
Add initial workload set tests
dsplaisted Mar 19, 2024
bcc7037
Updates to workload config command
dsplaisted Mar 20, 2024
4a553e1
Add support for changing version of installed SDK in VM tests
dsplaisted Mar 27, 2024
6bbd2b7
Add test for updating workloads in workload set mode with no workload…
dsplaisted Mar 27, 2024
d884497
Remove `dotnet workload update --mode <mode>`
dsplaisted Mar 27, 2024
7ecfc8a
Code review feedback and cleanup
dsplaisted Apr 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Show workload version even if no workload set is installed
  • Loading branch information
@dsplaisted
dsplaisted committed Mar 18, 2024
commit 90cd2f5e826b2c394005c76e69f4f7b0a8b7345e
5 changes: 0 additions & 5 deletions ...esolvers/Microsoft.NET.Sdk.WorkloadManifestReader/SdkDirectoryWorkloadManifestProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,11 +159,6 @@ public void RefreshWorkloadManifests()
return _workloadSet?.Version!;
}

if (InstallStateContents.FromPath(Path.Combine(WorkloadInstallType.GetInstallStateFolder(_sdkVersionBand, _sdkRootPath), "default.json")).UseWorkloadSets == true)
Copy link
Contributor

@Forgind Forgind Apr 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd want this to change to echo the version for the current SDK, per our discussion this morning.

Copy link
Member Author

@dsplaisted dsplaisted Apr 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've filed an issue to track the further changes needed: #40005

{
return null;
}

using (SHA256 sha256Hash = SHA256.Create())
{
byte[] bytes = sha256Hash.ComputeHash(Encoding.UTF8.GetBytes(string.Join(";",
Expand Down