Skip to content

Conversation

@am11
Copy link
Member

@am11 am11 commented Feb 26, 2025

Now that it's documented https://learn.microsoft.com/dotnet/api/system.net.networkcredential#remarks and no longer an internal property, lets make it consistent with rest of the config options (without the leading underscore).

@ghost ghost added Area-Infrastructure untriaged Request triage from a team member labels Feb 26, 2025
@am11
Copy link
Member Author

am11 commented Feb 26, 2025

cc @filipnavara, @wfurt, @rzikm

@filipnavara
Copy link
Member

I'm torn about this. Technically you are right. It should have never made the documentation with the current name and the ship has sailed on that. Changing the name now will make the documentation invalid and also any usage of the property in the wild. I still consider the option to be an unsupported compatibility hack which happens to be useful for testing or workarounds. I'll defer the decision to others, but thanks for tagging me and keeping me in the loop!

@filipnavara
Copy link
Member

I did a quick GitHub search and didn't find any projects using the _UseManagedNtlm property aside from dotnet/sdk, dotnet/runtime and their forks.

There's a usage in dotnet/runtime that would have to be updated if this goes through:
https://github.com/dotnet/runtime/blob/f5c73447ca9dcb3407d0143829bbf708c04170c1/src/tools/illink/src/ILLink.Tasks/build/Microsoft.NET.ILLink.targets#L53-L55

@wfurt
Copy link
Member

wfurt commented Feb 27, 2025

I'm OK either way. We can always document it as breaking change to make it more visible. I would think the need for this is small now....

@rzikm
Copy link
Member

rzikm commented Mar 3, 2025

I am on the same page as wfurt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Infrastructure untriaged Request triage from a team member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants