Remove emsdk packages from Version.Details.xml #50407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were removed in dotnet/dotnet#1686 but got messed up in the dependency flow revert issues.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes emsdk (Emscripten SDK) packages from dependency files that were inadvertently re-added during dependency flow revert issues, after being previously removed in PR #1686.
- Removes Emscripten SDK dependency entries from Version.Details.xml
- Removes corresponding package version properties from Version.Details.props
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/Version.Details.xml | Removes two Emscripten SDK dependency entries |
| eng/Version.Details.props | Removes package version properties and version aliases for Emscripten SDK packages |
ViktorHofer
approved these changes
Aug 21, 2025
3 tasks
akoeplinger
added a commit
that referenced
this pull request
Aug 26, 2025
(cherry picked from commit 66d3f47)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were removed in dotnet/dotnet#1686 but got messed up in the dependency flow revert issues.