Skip to content

Fix solution parsing in dotnet test for Microsoft.Testing.Platform #51411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Youssef1313 merged 15 commits into from
Nov 18, 2025
Merged

Fix solution parsing in dotnet test for Microsoft.Testing.Platform #51411

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
e763d34
Fix solution parsing in dotnet test for Microsoft.Testing.Platform
Youssef1313 Oct 22, 2025
7a3920a
Add ProjectShouldBuild
Youssef1313 Oct 23, 2025
6ef9d54
Hack
Youssef1313 Oct 23, 2025
304b212
Add comment
Youssef1313 Oct 23, 2025
b58730f
A bit of progress
Youssef1313 Oct 31, 2025
8b11323
Fix
Youssef1313 Oct 31, 2025
cdb835d
Merge branch 'release/10.0.2xx' into dev/ygerges/parse-sln
Youssef1313 Nov 11, 2025
8a749af
Add tests for solution filter with shared projects and platform confi…
Copilot Nov 12, 2025
c5f0cb1
Ensure full path is passed to SolutionFile.Parse
Youssef1313 Nov 12, 2025
f4d2700
Non buildable
Youssef1313 Nov 12, 2025
21a1db7
Update test
Youssef1313 Nov 15, 2025
af02344
Fix test
Youssef1313 Nov 15, 2025
b21d084
Fix solution filter path separators for .slnx files on Windows (#51770)
Copilot Nov 16, 2025
e58f7ab
Case sensitivity, nullability
Youssef1313 Nov 18, 2025
58c5531
Improve comments
Youssef1313 Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix test
  • Loading branch information
@Youssef1313
Youssef1313 authored Nov 15, 2025
commit af0234446fe668af963148bdab4e08f6683e6da5
4 changes: 2 additions & 2 deletions test/dotnet.Tests/CommandTests/Test/GivenDotnetTestBuildsAndRunsTestsWithDifferentOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -598,12 +598,12 @@ public void RunWithSolutionAndPlatformConfiguration_ShouldRespectPlatform(string

string testSolutionPath = "MultiTestProjectSolutionWithPlatforms.slnx";

// Test with x86 platform - OtherTestProject should NOT be included (no Build.0 for x86)
// Test with "NonWindows" platform - OtherTestProject should NOT be included
CommandResult resultX86 = new DotnetTestCommand(Log, disableNewOutput: false)
.WithWorkingDirectory(testInstance.Path)
.Execute(MicrosoftTestingPlatformOptions.SolutionOption.Name, testSolutionPath,
MicrosoftTestingPlatformOptions.ConfigurationOption.Name, configuration,
"--property:Platform=x86");
"--property:Platform=NonWindows");

// Validate that TestProject ran but OtherTestProject did not (not marked for build on x86)
resultX86.StdOut.Should().Contain("TestProject.dll");
Expand Down
Loading