Template Engine CLI commands: separate definitions from implementations #51747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmat
force-pushed
the
TemplateEngineCommands
branch
from
4ee7b04 to
66cc417
Compare
3 tasks
tmat
force-pushed
the
TemplateEngineCommands
branch
from
66cc417 to
95d879f
Compare
5 tasks
tmat
commented
Nov 14, 2025
src/Cli/Microsoft.TemplateEngine.Cli/Microsoft.TemplateEngine.Cli.csproj
Show resolved
Hide resolved
This was referenced Nov 15, 2025
3 tasks
joeloff
reviewed
Nov 19, 2025
joeloff
approved these changes
Nov 21, 2025
Member
joeloff
left a comment
joeloff
left a comment
There was a problem hiding this comment.
LGTM, the refactoring makes for a much cleaner design
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #51748
Follow ups:
NewCommandFactory.Createshould returnNewCommand