Skip to content

Fix muxer version handling to use runtime versions instead of SDK versions #51971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsplaisted merged 12 commits into from
Dec 12, 2025
Merged

Fix muxer version handling to use runtime versions instead of SDK versions #51971

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
452ee7b
Initial plan
Copilot Dec 2, 2025
32e7fc2
Fix muxer version handling to compare file versions instead of SDK ve…
Copilot Dec 2, 2025
7b7cd50
Add missing using statement for Xunit.Abstractions
Copilot Dec 2, 2025
665d370
Replace unit tests with integration tests in LibraryTests
Copilot Dec 2, 2025
0c5e201
Support muxer version detection on Linux/Mac using runtime versions
Copilot Dec 2, 2025
f16e380
Refactor muxer handling to use runtime version for all platforms
Copilot Dec 4, 2025
39a5412
Remove try-catch blocks and update tests to check muxer file directly
Copilot Dec 5, 2025
c8647dc
Remove GetRuntimeVersionFromArchive and add FileVersionInfo checks in…
Copilot Dec 5, 2025
3a81ab6
Fix muxer version comparison to check if runtime version changed
Copilot Dec 5, 2025
5d66e54
Assert file versions are not null on Windows instead of skipping
Copilot Dec 5, 2025
1c467b5
Add exception handling and RAII cleanup for muxer temp file
Copilot Dec 5, 2025
a5b5556
Apply code review feedback
dsplaisted Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Refactor muxer handling to use runtime version for all platforms 
- Remove FileVersionInfo logic entirely (all platforms now use same approach)
- Implement rename-extract-compare-restore workflow:
  1. Read existing muxer version from runtime directory
  2. Rename existing muxer to .tmp if present
  3. Extract archive (all files directly)
  4. Compare runtime versions
  5. Restore old muxer if new version < old version
- Simplify extraction code - no special muxer handling during extraction
- Remove ShouldUpdateMuxer, GetMuxerFileVersion, GetRuntimeVersionFromArchive, etc.
- Keep only GetLatestRuntimeVersionFromInstallRoot for version detection
- Update tests to check runtime versions instead of calling removed methods

Co-authored-by: dsplaisted <[email protected]>
  • Loading branch information
@dsplaisted
Copilot and dsplaisted committed Dec 4, 2025
commit f16e380490d589d77744e1f978fae57a28f42b02
Loading