Virtual project builder #52030
Open
Virtual project builder #52030
+779
−675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmat
force-pushed
the
VirtualProjectBuilder
branch
from
8d22646 to
a2d4dbc
Compare
This was referenced Dec 5, 2025
Open
Member
Author
|
@jjonescz @RikkiGibson ptal |
jjonescz
reviewed
Dec 8, 2025
src/Cli/Microsoft.TemplateEngine.Cli/Microsoft.TemplateEngine.Cli.csproj
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.ProjectTools/Microsoft.DotNet.ProjectTools.csproj
Outdated
Show resolved
Hide resolved
jjonescz
approved these changes
Dec 10, 2025
Member
|
@dotnet/run-file for another review |
Member
Author
|
/ba-g #52032 |
RikkiGibson
reviewed
Dec 10, 2025
Member
RikkiGibson
left a comment
RikkiGibson
left a comment
There was a problem hiding this comment.
Done review pass. Overall looks good but did want to follow up on the temp directory thing.
RikkiGibson
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate stateless, CLI-independent logic from
VirtualProjectBuildingCommandto a new typeVirtualProjectBuilder.This can be used to create
ProjectInstancefor file-based project, e.g. in dotnet-watch.