-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Workload manifests for net11 #52031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Workload manifests for net11 #52031
Conversation
|
this won't correctly detect installed net11 workloads until dotnet/runtime#121853 lands |
|
As a follow up we should do something like --- a/src/Workloads/Manifests/Microsoft.NET.Workload.Emscripten.Current.Manifest/WorkloadManifest.json.in
+++ b/src/Workloads/Manifests/Microsoft.NET.Workload.Emscripten.Current.Manifest/WorkloadManifest.json.in
@@ -1,6 +1,12 @@
{
"version": "${WorkloadVersion}",
"workloads": {
+ "microsoft-net-sdk-emscripten-${NetVersion}" : {
+ "abstract": true,
+ "description": "Emscripten SDK compiler tooling for ${NetVersion}.0",
+ "extends": "microsoft-net-sdk-emscripten"
+ "platforms": [ "win-x64", "win-arm64", "linux-x64", "linux-arm64", "linux-musl-x64", "linux-musl-arm64", "osx-x64", "osx-arm64" ]
+ }
"microsoft-net-sdk-emscripten": {
"abstract": true,
"description": "Emscripten SDK compiler tooling for ${NetVersion}.0",to make it easier to break the circular reference of workload versions on major version bumps. |
…-<platform>-net10' workload doesn't exist yet. Looks like this will be fixed with dotnet/sdk#52031.
…-<platform>-net10' workload doesn't exist yet. Looks like this will be fixed with dotnet/sdk#52031.
|
Runtime has merged net11 branding and targeting. Now we wait for flow to dotnet/dotnet and then backflow to sdk. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds .NET 10 workload manifests for Emscripten and Mono toolchains, and updates the Current manifests to target .NET 11. The changes enable workload support for .NET 10.0 while advancing the "Current" version to 11.0.
Key changes:
- Added complete net10 manifest definitions for both Mono.Toolchain and Emscripten workloads
- Updated Current manifests from net10 to net11 version references
- Added net10 version tracking variables and Emscripten version configuration
Reviewed changes
Copilot reviewed 27 out of 27 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/Workloads/Manifests/Microsoft.NET.Workload.Mono.Toolchain.net10.Manifest/WorkloadManifest.json.in |
Defines net10 workload manifest structure including wasm-tools, wasm-experimental, wasi-experimental, and mobile workloads |
src/Workloads/Manifests/Microsoft.NET.Workload.Mono.Toolchain.net10.Manifest/WorkloadManifest.targets.in |
MSBuild targets for net10 workload including platform-specific imports and property configuration |
src/Workloads/Manifests/Microsoft.NET.Workload.Mono.Toolchain.net10.Manifest/Microsoft.NET.Workload.Mono.Toolchain.net10.Manifest.proj |
Build project for generating net10 manifest files with template substitution |
src/Workloads/Manifests/Microsoft.NET.Workload.Mono.Toolchain.net10.Manifest/localize/*.json |
Localized workload descriptions for 13 languages |
src/Workloads/Manifests/Microsoft.NET.Workload.Emscripten.net10.Manifest/WorkloadManifest.json.in |
Emscripten SDK workload manifest for net10 with Node, Python, Cache and Sdk packs |
src/Workloads/Manifests/Microsoft.NET.Workload.Emscripten.net10.Manifest/WorkloadManifest.targets.in |
MSBuild targets for net10 Emscripten workload imports |
src/Workloads/Manifests/Microsoft.NET.Workload.Emscripten.net10.Manifest/Microsoft.NET.Workload.Emscripten.net10.Manifest.proj |
Build project for net10 Emscripten manifest generation |
src/Workloads/Manifests/Microsoft.NET.Workload.Mono.Toolchain.Current.Manifest/WorkloadManifest.targets.in |
Updated Current manifest to reference net11 instead of net10, added net10-specific version properties |
src/Workloads/Manifests/Microsoft.NET.Workload.Mono.Toolchain.Current.Manifest/Microsoft.NET.Workload.Mono.Toolchain.Current.Manifest.proj |
Updated NetVersion from net10 to net11, added RuntimeVersionNet10 variable |
src/Workloads/Manifests/Microsoft.NET.Workload.Emscripten.Current.Manifest/WorkloadManifest.targets.in |
Updated CurrentEmsdkTarget from 9.0/10.0 to 10.0/11.0 |
src/Workloads/Manifests/Microsoft.NET.Workload.Emscripten.Current.Manifest/Microsoft.NET.Workload.Emscripten.Current.Manifest.proj |
Updated NetVersion from net10 to net11 |
src/Layout/redist/targets/BundledManifests.targets |
Added net10 to bundled manifests list for both emscripten and mono.toolchain |
src/Cli/dotnet/Commands/Workload/Install/NetSdkMsiInstallerClient.InstallRecords.cs |
Added net10 manifest IDs to the cased manifest list |
eng/Versions.props |
Added VersionFeature100, VersionFeature100ForWorkloads, and EmscriptenVersionNet10 properties |
...oads/Manifests/Microsoft.NET.Workload.Mono.Toolchain.net10.Manifest/WorkloadManifest.json.in
Outdated
Show resolved
Hide resolved
…net10.Manifest/WorkloadManifest.json.in Co-authored-by: Copilot <[email protected]>
…-<platform>-net10' workload doesn't exist yet. Looks like this will be fixed with dotnet/sdk#52031.
…-<platform>-net10' workload doesn't exist yet. Looks like this will be fixed with dotnet/sdk#52031.
Add the net10 Manifests for emscripten and mono.