Remove obsolete TODO referencing resolved issue #26169 #52130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TODO comment referenced issue #26169 which has been resolved. The issue discussion concluded that: 1. Adding 'sealed' to interface members should be flagged (implemented in PR #27421) 2. Adding 'virtual' to members should only be flagged in strict mode (already correctly implemented) The current implementation is correct and no further expansion is needed. The TODO has been replaced with a clear comment explaining the strict mode behavior. Co-authored-by: krwq <[email protected]>
Copilot
AI
changed the title
[WIP] Fix TODO comment in CannotAddOrRemoveVirtualKeyword
Remove obsolete TODO referencing resolved issue #26169
Dec 11, 2025
krwq
approved these changes
Dec 11, 2025
Member
krwq
left a comment
krwq
left a comment
There was a problem hiding this comment.
Looks good to me. As @copilot mentioned this seems to be fixed by https://github.com/dotnet/sdk/pull/27421/files#diff-b7980ad2404d6e4b2524333bc66dba4f5542171e316ad4161bebe4e8bdfd624a
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes an obsolete TODO comment that referenced issue #26169, which has been resolved. The issue discussed establishing API compatibility rules for adding the virtual keyword to members. The resolution confirmed that adding virtual is only a breaking change in strict mode contexts, which the code already correctly implements.
Key Changes:
- Removed two-line TODO comment referencing resolved issue #26169
- Added single-line clarifying comment explaining the strict mode behavior
...ibility/ApiCompat/Microsoft.DotNet.ApiCompatibility/Rules/CannotAddOrRemoveVirtualKeyword.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
ericstj
approved these changes
Dec 11, 2025
ericstj
deleted the
copilot/fix-todo-in-cannotaddorremovevirtualkeyword
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #26169 discussed clarifying API compatibility rules for adding the
virtualkeyword. PR #27421 resolved it by adding a check forsealedon interface members. The discussion concluded that addingvirtualto members is only a breaking change in strict mode contexts, which is already correctly implemented.Changes
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.