Skip to content

Fix interaction of "csc only after msbuild" optimization and implicit build files #52133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jjonescz wants to merge 3 commits into
base: release/10.0.2xx
Choose a base branch
from
Open

Fix interaction of "csc only after msbuild" optimization and implicit build files #52133

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
139948d
Fix interaction of "csc only after msbuild" optimization and implicit…
jjonescz Dec 11, 2025
f9e57b5
Remove unnecessary `?.`
jjonescz Dec 11, 2025
7d3df77
Check source file sooner if possible
jjonescz Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unnecessary ?.
  • Loading branch information
@jjonescz
jjonescz committed Dec 11, 2025
commit f9e57b553a0af11b6f988a65491fa9402f882665
4 changes: 2 additions & 2 deletions src/Cli/dotnet/Commands/Run/VirtualProjectBuildingCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -939,11 +939,11 @@ private BuildLevel GetBuildLevel(out CacheInfo cache)
{
Reporter.Verbose.WriteLine("No CSC arguments from previous run.");
}
else if (cache.PreviousEntry?.Run == null)
else if (cache.PreviousEntry.Run == null)
{
Reporter.Verbose.WriteLine("We have CSC arguments but not run properties. That's unexpected.");
}
else if (cache.PreviousEntry?.BuildResultFile == null)
else if (cache.PreviousEntry.BuildResultFile == null)
{
Reporter.Verbose.WriteLine("We have CSC arguments but not build result file. That's unexpected.");
}
Expand Down