Skip to content

ClickOnce: improve application manifest file detection #773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
dtivel wants to merge 8 commits into
base: main
Choose a base branch
from
+660 −30
Draft

ClickOnce: improve application manifest file detection #773

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6a01d81
Add a new method to look up the app manifest from the deployment mani…
jmtpt Aug 27, 2024
929a797
detect the app manifest by looking it up, rather than assuming we hav…
jmtpt Aug 27, 2024
31708b4
Add some dummy content for the deployment manifest so that it can be …
jmtpt Aug 27, 2024
c2cfe06
handle codebase values that are uris
jmtpt Aug 28, 2024
11499e0
fix file path and version string
jmtpt Aug 28, 2024
1b46d6e
add test to verify that we detect/sign the correct manifest file
jmtpt Aug 28, 2024
0bf23a6
Apply feedback
dtivel Sep 18, 2024
17f1051
Load XML documents safely and add tests.
dtivel Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
detect the app manifest by looking it up, rather than assuming we hav… 
…e 0/1 files with a .manifest extension
  • Loading branch information
@jmtpt
jmtpt committed Aug 27, 2024
commit 929a797d65702e836db036feb19108b6b69a081e
4 changes: 2 additions & 2 deletions src/Sign.Core/DataFormatSigners/ClickOnceSigner.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,8 @@ await Parallel.ForEachAsync(files, _parallelOptions, async (file, state) =>

// Inner files are now signed
// now look for the manifest file and sign that if we have one

FileInfo? manifestFile = filteredFiles.SingleOrDefault(f => ".manifest".Equals(f.Extension, StringComparison.OrdinalIgnoreCase));
var appManifestFromDeploymentManifest = GetApplicationManifestForDeploymentManifest(file);
FileInfo? manifestFile = filteredFiles.SingleOrDefault(f => f.Name.Equals(appManifestFromDeploymentManifest?.Name, StringComparison.OrdinalIgnoreCase));

string fileArgs = $@"-update ""{manifestFile}"" {args}";

Expand Down