Skip to content

Add logging through to Azure services #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dtivel merged 21 commits into from
Feb 13, 2025
Merged

Add logging through to Azure services #808

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
cfb6dd1
Add service addition functionality to ServiceProviderFactory
clairernovotny Dec 11, 2024
30cf2cd
Refactor TrustedSigningService for DI and add Azure support
clairernovotny Dec 11, 2024
bf49764
cleanup
clairernovotny Dec 11, 2024
b23dbea
Rename private field `servicesToAdd` to `_servicesToAdd`
clairernovotny Dec 11, 2024
69a9cdf
Fix parameter name in test
clairernovotny Dec 11, 2024
41b08eb
Some formatting and renames based on feedback
clairernovotny Dec 11, 2024
6771ae1
Update editorconfig to match VS output, add additioal rules and sort …
clairernovotny Dec 11, 2024
991901d
Wrapped the Stream object in a using statement to ensure it is proper…
clairernovotny Dec 12, 2024
b76bd5b
Enhance Azure Key Vault integration
clairernovotny Dec 12, 2024
7f3a169
Add additional logging
clairernovotny Dec 12, 2024
92d6692
Refactor KeyVaultService and update tests
clairernovotny Dec 12, 2024
808959c
Update tests
clairernovotny Dec 13, 2024
0b2abdd
Finish tests
clairernovotny Dec 13, 2024
23f8be2
Revert editorconfig update. separate pr for that
clairernovotny Dec 13, 2024
a65bd80
Update src/Sign.SignatureProviders.TrustedSigning/Resources.resx
clairernovotny Dec 13, 2024
9bba4f3
Ensure the cert details are printed on a new line
clairernovotny Dec 13, 2024
e6f51ab
Handle the error with a better output message instead of a stack trac…
clairernovotny Dec 13, 2024
d2407d3
Apply feedback.
dtivel Feb 11, 2025
cff5177
Bump dependency version.
dtivel Feb 11, 2025
d715764
Apply feedback.
dtivel Feb 11, 2025
9836878
Add test
dtivel Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert editorconfig update. separate pr for that
  • Loading branch information
@clairernovotny @dtivel
clairernovotny authored and dtivel committed Feb 10, 2025
commit 23f8be2d95dfbf5627d5dedae37ad4f2dee2e45e
273 changes: 3 additions & 270 deletions .editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,286 +5,19 @@ insert_final_newline = true
indent_style = space
indent_size = 4
trim_trailing_whitespace = true
dotnet_style_allow_multiple_blank_lines_experimental = true:silent

[*.{csproj,md,props,targets,yml}]
indent_size = 2

[*.cs]
#### Core EditorConfig Options ####

# Indentation and spacing
indent_size = 4
indent_style = space
tab_width = 4

# New line preferences
end_of_line = crlf

#### .NET Code Actions ####

# Type members
dotnet_hide_advanced_members = false
dotnet_member_insertion_location = with_other_members_of_the_same_kind
dotnet_property_generation_behavior = prefer_auto_properties

# Symbol search
dotnet_search_reference_assemblies = true

# Organize usings
dotnet_separate_import_directive_groups = true
dotnet_sort_system_directives_first = true
file_header_template = Licensed to the .NET Foundation under one or more agreements.\nThe .NET Foundation licenses this file to you under the MIT license.\nSee the LICENSE.txt file in the project root for more information.

# this. and Me. preferences
dotnet_style_qualification_for_field = false:silent
dotnet_style_qualification_for_property = false:silent
dotnet_style_qualification_for_method = false:silent
dotnet_style_qualification_for_event = false:silent

# Language keywords vs BCL types preferences
dotnet_style_predefined_type_for_locals_parameters_members = true:silent
dotnet_style_predefined_type_for_member_access = true:silent

# Parentheses preferences
dotnet_style_parentheses_in_arithmetic_binary_operators = always_for_clarity:silent
dotnet_style_parentheses_in_other_binary_operators = always_for_clarity:silent
dotnet_style_parentheses_in_other_operators = never_if_unnecessary:silent
dotnet_style_parentheses_in_relational_binary_operators = always_for_clarity:silent

# Modifier preferences
dotnet_style_require_accessibility_modifiers = for_non_interface_members:silent

# Expression-level preferences
dotnet_prefer_system_hash_code = true:suggestion
dotnet_style_coalesce_expression = true:suggestion
dotnet_style_collection_initializer = true:suggestion
dotnet_style_explicit_tuple_names = true:suggestion
dotnet_style_namespace_match_folder = true:suggestion
dotnet_style_null_propagation = true:suggestion
dotnet_style_object_initializer = true:suggestion
dotnet_style_operator_placement_when_wrapping = beginning_of_line
dotnet_style_prefer_auto_properties = true:silent
dotnet_style_prefer_collection_expression = when_types_loosely_match:suggestion
dotnet_style_prefer_compound_assignment = true:suggestion
dotnet_style_prefer_conditional_expression_over_assignment = true:silent
dotnet_style_prefer_conditional_expression_over_return = true:silent
dotnet_style_prefer_foreach_explicit_cast_in_source = when_strongly_typed:suggestion
dotnet_style_prefer_inferred_anonymous_type_member_names = true:suggestion
dotnet_style_prefer_inferred_tuple_names = true:suggestion
dotnet_style_prefer_is_null_check_over_reference_equality_method = true:suggestion
dotnet_style_prefer_simplified_boolean_expressions = true:suggestion
dotnet_style_prefer_simplified_interpolation = true:suggestion

# Field preferences
dotnet_style_readonly_field = true:suggestion

# Parameter preferences
dotnet_code_quality_unused_parameters = all:warning

# Suppression preferences
dotnet_remove_unnecessary_suppression_exclusions = none

# New line preferences
dotnet_style_allow_multiple_blank_lines_experimental = true:silent
dotnet_style_allow_statement_immediately_after_block_experimental = true:silent

#### C# Coding Conventions ####

# var preferences
csharp_style_var_elsewhere = false:silent
csharp_style_var_for_built_in_types = false:silent
csharp_style_var_when_type_is_apparent = false:silent

# Expression-bodied members
csharp_style_expression_bodied_accessors = true:silent
csharp_style_expression_bodied_constructors = false:silent
csharp_style_expression_bodied_indexers = true:silent
csharp_style_expression_bodied_lambdas = true:silent
csharp_style_expression_bodied_local_functions = false:silent
csharp_style_expression_bodied_methods = false:silent
csharp_style_expression_bodied_operators = false:silent
csharp_style_expression_bodied_properties = true:silent

# Pattern matching preferences
csharp_style_pattern_matching_over_as_with_null_check = true:suggestion
csharp_style_pattern_matching_over_is_with_cast_check = true:suggestion
csharp_style_prefer_extended_property_pattern = true:suggestion
csharp_style_prefer_not_pattern = true:suggestion
csharp_style_prefer_pattern_matching = true:silent
csharp_style_prefer_switch_expression = true:suggestion

# Null-checking preferences
csharp_style_conditional_delegate_call = true:suggestion

# Modifier preferences
csharp_prefer_static_anonymous_function = true:suggestion
csharp_prefer_static_local_function = true:suggestion
csharp_preferred_modifier_order = public,private,protected,internal,file,static,extern,new,virtual,abstract,sealed,override,readonly,unsafe,required,volatile,async
csharp_style_prefer_readonly_struct = true:suggestion
csharp_style_prefer_readonly_struct_member = true:suggestion

# Code-block preferences
csharp_prefer_braces = true:silent
csharp_prefer_simple_using_statement = false:suggestion
csharp_prefer_system_threading_lock = true:suggestion
csharp_style_namespace_declarations = block_scoped:silent
csharp_style_prefer_method_group_conversion = true:silent
csharp_style_prefer_primary_constructors = true:suggestion
csharp_style_prefer_top_level_statements = true:silent

# Expression-level preferences
csharp_prefer_simple_default_expression = true:suggestion
csharp_style_deconstructed_variable_declaration = true:suggestion
csharp_style_implicit_object_creation_when_type_is_apparent = true:suggestion
csharp_style_inlined_variable_declaration = true:suggestion
csharp_style_prefer_index_operator = true:suggestion
csharp_style_prefer_local_over_anonymous_function = true:suggestion
csharp_style_prefer_null_check_over_type_check = true:suggestion
csharp_style_prefer_range_operator = true:suggestion
csharp_style_prefer_tuple_swap = true:suggestion
csharp_style_prefer_utf8_string_literals = true:suggestion
csharp_style_throw_expression = true:suggestion
csharp_style_unused_value_assignment_preference = discard_variable:suggestion
csharp_style_unused_value_expression_statement_preference = discard_variable:silent

# 'using' directive preferences
csharp_using_directive_placement = outside_namespace:silent

# New line preferences
csharp_style_allow_blank_line_after_colon_in_constructor_initializer_experimental = true:silent
csharp_style_allow_blank_line_after_token_in_arrow_expression_clause_experimental = true:silent
csharp_style_allow_blank_line_after_token_in_conditional_expression_experimental = true:silent
csharp_style_allow_blank_lines_between_consecutive_braces_experimental = true:silent
csharp_style_allow_embedded_statements_on_same_line_experimental = true:silent

#### C# Formatting Rules ####

# New line preferences
csharp_new_line_before_catch = true:silent
csharp_new_line_before_else = true:silent
csharp_new_line_before_finally = true:silent
csharp_new_line_before_members_in_anonymous_types = true:silent
csharp_new_line_before_members_in_object_initializers = true:silent
csharp_new_line_before_open_brace = all
csharp_new_line_between_query_expression_clauses = true:silent

# Indentation preferences
csharp_indent_block_contents = true:suggestion
csharp_indent_braces = false:suggestion
csharp_indent_case_contents = true:suggestion
csharp_indent_case_contents_when_block = true:suggestion
csharp_indent_labels = no_change
csharp_indent_switch_labels = true:suggestion

# Space preferences
csharp_space_after_cast = false:silent
csharp_space_after_colon_in_inheritance_clause = true:silent
csharp_space_after_comma = true:silent
csharp_space_after_dot = false:silent
csharp_space_after_keywords_in_control_flow_statements = true:silent
csharp_space_after_semicolon_in_for_statement = true:silent
csharp_space_around_binary_operators = before_and_after
csharp_space_around_declaration_statements = false:silent
csharp_space_before_colon_in_inheritance_clause = true:silent
csharp_space_before_comma = false:silent
csharp_space_before_dot = false:silent
csharp_space_before_open_square_brackets = false:silent
csharp_space_before_semicolon_in_for_statement = false:silent
csharp_space_between_empty_square_brackets = false:silent
csharp_space_between_method_call_empty_parameter_list_parentheses = false:silent
csharp_space_between_method_call_name_and_opening_parenthesis = false:silent
csharp_space_between_method_call_parameter_list_parentheses = false:silent
csharp_space_between_method_declaration_empty_parameter_list_parentheses = false:silent
csharp_space_between_method_declaration_name_and_open_parenthesis = false:silent
csharp_space_between_method_declaration_parameter_list_parentheses = false:silent
csharp_space_between_parentheses = false:silent
csharp_space_between_square_brackets = false:silent

#### Naming styles ####

# Naming rules

dotnet_naming_rule.interface_should_be_begins_with_i.severity = suggestion
dotnet_naming_rule.interface_should_be_begins_with_i.symbols = interface
dotnet_naming_rule.interface_should_be_begins_with_i.style = begins_with_i

dotnet_naming_rule.types_should_be_pascal_case.severity = suggestion
dotnet_naming_rule.types_should_be_pascal_case.symbols = types
dotnet_naming_rule.types_should_be_pascal_case.style = pascal_case

dotnet_naming_rule.non_field_members_should_be_pascal_case.severity = suggestion
dotnet_naming_rule.non_field_members_should_be_pascal_case.symbols = non_field_members
dotnet_naming_rule.non_field_members_should_be_pascal_case.style = pascal_case

#### Naming styles ####

# Naming rules

dotnet_naming_rule.interface_should_be_begins_with_i.severity = suggestion
dotnet_naming_rule.interface_should_be_begins_with_i.symbols = interface
dotnet_naming_rule.interface_should_be_begins_with_i.style = begins_with_i

dotnet_naming_rule.types_should_be_pascal_case.severity = suggestion
dotnet_naming_rule.types_should_be_pascal_case.symbols = types
dotnet_naming_rule.types_should_be_pascal_case.style = pascal_case

dotnet_naming_rule.non_field_members_should_be_pascal_case.severity = suggestion
dotnet_naming_rule.non_field_members_should_be_pascal_case.symbols = non_field_members
dotnet_naming_rule.non_field_members_should_be_pascal_case.style = pascal_case

dotnet_naming_rule.private_fields_underscored.severity = error
dotnet_naming_rule.private_fields_underscored.symbols = private_fields
dotnet_naming_rule.private_fields_underscored.style = underscored

dotnet_naming_rule.private_static_fields_none.severity = none
dotnet_naming_rule.private_static_fields_none.symbols = private_static_fields
dotnet_naming_rule.private_static_fields_none.style = underscored


# Symbol specifications

dotnet_naming_symbols.interface.applicable_kinds = interface
dotnet_naming_symbols.interface.applicable_accessibilities = public, internal, private, protected, protected_internal, private_protected
dotnet_naming_symbols.interface.required_modifiers =

dotnet_naming_symbols.types.applicable_kinds = class, struct, interface, enum
dotnet_naming_symbols.types.applicable_accessibilities = public, internal, private, protected, protected_internal, private_protected
dotnet_naming_symbols.types.required_modifiers =

dotnet_naming_symbols.non_field_members.applicable_kinds = property, event, method
dotnet_naming_symbols.non_field_members.applicable_accessibilities = public, internal, private, protected, protected_internal, private_protected
dotnet_naming_symbols.non_field_members.required_modifiers =

dotnet_naming_symbols.private_fields.applicable_kinds = field
dotnet_naming_symbols.private_fields.applicable_accessibilities = private

dotnet_naming_symbols.private_static_fields.applicable_kinds = field
dotnet_naming_symbols.private_static_fields.applicable_accessibilities = private
dotnet_naming_symbols.private_static_fields.required_modifiers = static

# Naming styles

dotnet_naming_style.begins_with_i.required_prefix = I
dotnet_naming_style.begins_with_i.required_suffix =
dotnet_naming_style.begins_with_i.word_separator =
dotnet_naming_style.begins_with_i.capitalization = pascal_case

dotnet_naming_style.pascal_case.required_prefix =
dotnet_naming_style.pascal_case.required_suffix =
dotnet_naming_style.pascal_case.word_separator =
dotnet_naming_style.pascal_case.capitalization = pascal_case

dotnet_naming_style.underscored.capitalization =
dotnet_naming_style.underscored.required_prefix = _



# Analyzers
# IDE0063: Use simple 'using' statement
csharp_prefer_simple_using_statement = false

# CA2254: Template should be a static expression
# See https://github.com/dotnet/roslyn-analyzers/issues/5626
dotnet_diagnostic.CA2254.severity = none

# IDE0073: File header
dotnet_diagnostic.IDE0073.severity = warning
file_header_template = Licensed to the .NET Foundation under one or more agreements.\nThe .NET Foundation licenses this file to you under the MIT license.\nSee the LICENSE.txt file in the project root for more information.