Azure Key Vault: fix regression in Azure Key Vault signing #828
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #827
#808 and #822 introduced a regression.
In Azure Key Vault:
<scheme>://<authority><scheme>://<authority>/certificates/<certificateId><scheme>://<authority>/keys/<certificateId>#808 and #822 added calls to
CertificateClientBuilderExtensions.AddCertificateClient(...)andKeyClientBuilderExtensions.AddCryptographyClient(...).AddCertificateClient(...)has avaultUriparameter which must be the Key Vault URI, whileAddCryptographyClient(...)has avaultUriparameter which must be the private key's URI. Documentation for the latter says,vaultUrishould be "[t]he URI to a specific key in an Azure Key Vault, for example: https://my-vault.vault.azure.net/keys/my-key."However,
KeyVaultKeyIdentifier.VaultUriwas passed toAddCryptographyClient(...), and that returns the Key Vault URI. The fix is to use the private key URI we already constructed ourselves.