-
Notifications
You must be signed in to change notification settings - Fork 68
Add Microsoft.CodeAnalysis.CSharp 4.0.1 #357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@MichaelSimons I've removed the Is that an acceptable way to resolve? |
|
@chsienki - Can you explain in more detail what you meant by "netcoreapp3.1 versions as they don't seem to be supported"? I looked at the first commit's build failures and noticed an issue with the tooling that I just submitted a PR for. I will regenerate the source with this fix and update this PR. Aside from that, there do appear to be a number of issues in the generated source that will need to be analyzed and corrected. |
|
@chsienki - I see you made a number of hand edits already. Do you know if these are something we can tool? GenAPI is the underlying tooling being used. |
|
I regenerated the source but did not re-add microsoft.codeanalysis.common and microsoft.codeanalysis.csharp 3.1 nor did I undo the hand edits. Ideally the hand edits would be minimal so I am looking for input on how to generate these ref packages correctly. Having to make these many manual edits doesn't scale. Also we would ideally not be removing 3.1. |
|
@MichaelSimons Ok, I'll see if I can update the tool to generate the correct files. |
MichaelSimons
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rerun the generator to get the up-to-date changes?
| } | ||
| public static partial class WellKnownDiagnosticTags | ||
| { | ||
| public const string AnalyzerException |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider pulling these into a separate file so that we can re-run the generator. It will also help callout the manual fixes.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi @chsienki, @andriipatsula is starting to look at the broader problems of reference source generation and we had a couple questions about the changes. It looks like the major changes from the generated source were:
Thanks! |
|
This PR has been superseded by #416. |
Generated via
.\generate.sh --pkg Microsoft.CodeAnalysis.CSharp,4.0.1Needed so we can pin the razor generator to version 4.0.1 in the SDK without diverging source build (see dotnet/sdk#24130 )
I think it looks right, but I'm new at this :)