Skip to content

Conversation

@chsienki
Copy link
Member

Generated via .\generate.sh --pkg Microsoft.CodeAnalysis.CSharp,4.0.1

Needed so we can pin the razor generator to version 4.0.1 in the SDK without diverging source build (see dotnet/sdk#24130 )

I think it looks right, but I'm new at this :)

@chsienki
Copy link
Member Author

@MichaelSimons I've removed the netcoreapp3.1 versions as they don't seem to be supported, and manually fixed up the missing internal refs that was causing it to fail.

Is that an acceptable way to resolve?

@MichaelSimons
Copy link
Member

@chsienki - Can you explain in more detail what you meant by "netcoreapp3.1 versions as they don't seem to be supported"? I looked at the first commit's build failures and noticed an issue with the tooling that I just submitted a PR for.

I will regenerate the source with this fix and update this PR. Aside from that, there do appear to be a number of issues in the generated source that will need to be analyzed and corrected.

@MichaelSimons
Copy link
Member

@chsienki - I see you made a number of hand edits already. Do you know if these are something we can tool? GenAPI is the underlying tooling being used.

@MichaelSimons
Copy link
Member

I regenerated the source but did not re-add microsoft.codeanalysis.common and microsoft.codeanalysis.csharp 3.1 nor did I undo the hand edits.

Ideally the hand edits would be minimal so I am looking for input on how to generate these ref packages correctly. Having to make these many manual edits doesn't scale. Also we would ideally not be removing 3.1.

@chsienki
Copy link
Member Author

@MichaelSimons Ok, I'll see if I can update the tool to generate the correct files.

Copy link
Member

@MichaelSimons MichaelSimons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rerun the generator to get the up-to-date changes?

}
public static partial class WellKnownDiagnosticTags
{
public const string AnalyzerException
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider pulling these into a separate file so that we can re-run the generator. It will also help callout the manual fixes.

@MichaelSimons
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@crummel
Copy link
Contributor

crummel commented Jun 15, 2022

Hi @chsienki, @andriipatsula is starting to look at the broader problems of reference source generation and we had a couple questions about the changes. It looks like the major changes from the generated source were:

  • nullable types: were these causing problems when compiling?
  • internal types: as we understand it these are required because GenApi doesn't create them and this assembly has several InternalsVisibleTo attributes for other Roslyn assemblies. Is that correct?
  • CLSCompliant - this seems like a known GenApi issue.
  • netcoreapp3.1 which wasn't needed in this use-case: do you know what problem this was causing?

Thanks!

@MichaelSimons
Copy link
Member

This PR has been superseded by #416.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants