-
Notifications
You must be signed in to change notification settings - Fork 68
feat: add tooling for generating text-only packages #427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add tooling for generating text-only packages #427
Conversation
If the licenses are actually proprietary, that makes it impossible for open source projects to consume this repo and source-build. What would re-licensing look like? |
generate-text-packs.sh
Outdated
| fi | ||
|
|
||
| # -p:RestoreAdditionalProjectSources -> specifies additional Nuget package sources, including feeds: https://docs.microsoft.com/en-us/nuget/reference/msbuild-targets#restore-properties | ||
| # -p:RestoreUsingNuGetTargets -> switch that controls who will restore the project; if set to `false`, Arcade's Build.proj will execute the Restore target of the project itself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice discovery!
ce62b9d to
c23c83c
Compare
|
Update - incorporating PR feedback:
|
I believe Dan S went and got permission to put these under the licenses as currently checked-in so we shouldn't revert. @leecow can probably confirm. |
I confirmed this with Dan S. |
c23c83c to
92cac66
Compare
|
Update - incorporating PR feedback:
|
92cac66 to
f53bf43
Compare
|
Update - incorporating PR feedback:
|
f53bf43 to
1b482a2
Compare
MichaelSimons
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look nice. I just have a couple comments.
1b482a2 to
9f011d3
Compare
9f011d3 to
0b498d7
Compare
|
@oleksandr-didyk, When making changes in response to code review feedback, I find it beneficial to preserve the individual commits. It helps the code reviewers see what was changed versus having to re-review the entire set of changes. The commits can be squashed via GitHub when merging the PR. |
0b498d7 to
b551ba3
Compare
Overview
Resolves dotnet/source-build#2655
This PR adds tooling for generating text-only packages. The entrypoint for the tooling is the newly added
./generate-text-packs.shscript, that allows the user to provide a package name, multiple package versions and multiple additional NuGet feeds to restore the package from.The tooling is a modified version of similar MSBuild logic from
dotnet/installer(source)The tool was also used to re-generate almost all of the currently present text-only packages
Other changes
./generate.shto./generate-ref-packs.shto better represent its functionality and not collide with the newly added./generate-text-packs.sh*.csprojfiles forMicrosoft.CodeAnalysis.CollectionsandMicrosoft.NetCore.PlatformLICENSEfiles withdotnet_library_license(change coming from the NuGet packages themselves)<licenseUrl>in*.nuspec(change coming from the NuGet packages themselves)Open questions
AllowedTextOnlyExtensionslist valid or should be updated / removed completely? Originally copied fromdotnet/installerwith small additions of the following extensions:.-,.resx,.rtfand.xlf*.nuspecfiles differ from those available in the NuGet packages by a few lines specified below. Is this something that should be made part of the tooling or could be added manually by the user?