Skip to content

Set BuildAllPackages in corefx #1334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dseefeld merged 2 commits into from
Oct 29, 2019
Merged

Set BuildAllPackages in corefx #1334

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2a426c
Set BuildAllPackages in corefx
dseefeld Oct 28, 2019
8d92890
Fix BuildAllPackages...should be true
dseefeld Oct 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Set BuildAllPackages in corefx 
Update corefx project to set property to build all packages.  After the merge of #1237, corefx in source-build stopped building all packages.  With the latest update to corefx brought in by #1237, building all packages is gated by the BuildAllPackages property here: https://github.com/dotnet/corefx/blob/c1778515a3bee34cc09c757b5563d0af0c8b1e99/src/packages.builds#L8-L12
  • Loading branch information
@dseefeld
dseefeld authored Oct 28, 2019
commit e2a426c3eba68b35a5c131a834ae69591b97ff8e
1 change: 1 addition & 0 deletions repos/corefx.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
<BuildArguments>$(BuildArguments) /p:ILAsmToolPath=$(ToolPackageExtractDir)coreclr-tools/</BuildArguments>
<BuildArguments>$(BuildArguments) /p:EnableVSTestReferences=false</BuildArguments>
<BuildArguments>$(BuildArguments) /p:ILLinkTrimAssembly=false</BuildArguments>
<BuildArguments>$(BuildArguments) /p:BuildAllPackages=false</BuildArguments>
<BuildArguments Condition="'$(OfflineBuild)' != 'true'">$(BuildArguments) /p:DotNetSourceBuildIntermediatePath=$(GeneratedSourcePathOnline)</BuildArguments>
<BuildArguments Condition="'$(OfflineBuild)' == 'true'">$(BuildArguments) /p:DotNetSourceBuildIntermediatePath=$(GeneratedSourcePathOffline)</BuildArguments>
<BuildArguments Condition="'$(OfflineBuild)' == 'true'">$(BuildArguments) /p:MicrosoftNETCoreDotNetHostPackageVersion=$(coresetupOutputPackageVersion)</BuildArguments>
Expand Down